[OGUI-1920] Encode filter query in route updates - #3602
Draft
isaachilly wants to merge 8 commits into
Draft
Conversation
isaachilly
force-pushed
the
bug/ILG/OGUI-1920/Fix-encoding-order-of-filter-parameter-q
branch
from
September 8, 2026 07:40
b422aad to
2270100
Compare
Centralised URL encoding for filters. Removed encoding in `LogFilter` so filter values are no longer pre-encoded before serialisation; keeping query generation in one place.
Update InfoLogger filter action tests to match fully encoded `q` parameter.
Adds round-trip tests in a separate mocha file. Removes old encoding tests.
Adds a `queryString` getter on `LogFilter` that uses shared `buildUrl` utilities, and updates `Model` to rely on that property when syncing route state.
This no longer has its corresponding encoder so it's pointless as the URL at this point will contain no `'\n` strings, they will all be percent-encoded.
isaachilly
force-pushed
the
bug/ILG/OGUI-1920/Fix-encoding-order-of-filter-parameter-q
branch
from
September 9, 2026 06:59
b6e3ad3 to
59052c7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Centralised URL encoding for filters.
Removed encoding in
LogFilterso filter values are no longer pre-encoded before serialisation; keeping query generation in one place.I have JIRA issue created