Skip to content

[PWGHF] XicToXiPiPi: enable BDT selection in KFParticle mode - #18598

Open
lubynets wants to merge 4 commits into
AliceO2Group:masterfrom
lubynets:xic-kf-ml
Open

[PWGHF] XicToXiPiPi: enable BDT selection in KFParticle mode#18598
lubynets wants to merge 4 commits into
AliceO2Group:masterfrom
lubynets:xic-kf-ml

Conversation

@lubynets

@lubynets lubynets commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

This PR adds KFParticle-specific variables to the HfMlResponseXicToXiPiPi.h features and changes candidateSelectorXicToXiPiPi.cxx accordingly.
Tagging @fgrosa

@github-actions github-actions Bot added the pwghf PWG-HF label Nov 4, 2026
@github-actions github-actions Bot changed the title XicToXiPiPi: enable BDT selection in KFParticle mode [PWGHF] XicToXiPiPi: enable BDT selection in KFParticle mode Nov 4, 2026
@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

@alibuild

alibuild commented Nov 4, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 67dc6ae at 2026-11-05 00:20:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGHF/Core/HfMlResponseXicToXiPiPi.h:116:45: error: 'aod' has not been declared
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGHF/Core/HfMlResponseXicToXiPiPi.h:116:72: error: expected '>' before 'ReconstructionType'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXicToXiPiPi.cxx:95:17: error: '<expression error>' in namespace 'o2::analysis' does not name a type
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXicToXiPiPi.cxx:96:17: error: '<expression error>' in namespace 'o2::analysis' does not name a type
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXicToXiPiPi.cxx:271:24: error: 'hfMlResponseDca' was not declared in this scope
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXicToXiPiPi.cxx:273:24: error: 'hfMlResponseKf' was not declared in this scope
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXicToXiPiPi.cxx:693:53: error: 'hfMlResponseDca' was not declared in this scope
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXicToXiPiPi.cxx:696:53: error: 'hfMlResponseKf' was not declared in this scope
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

alibuild commented Nov 4, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 67dc6ae at 2026-11-05 00:21:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGHF/Core/HfMlResponseXicToXiPiPi.h:116:45: error: 'aod' has not been declared
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGHF/Core/HfMlResponseXicToXiPiPi.h:116:72: error: expected '>' before 'ReconstructionType'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXicToXiPiPi.cxx:95:17: error: '<expression error>' in namespace 'o2::analysis' does not name a type
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXicToXiPiPi.cxx:96:17: error: '<expression error>' in namespace 'o2::analysis' does not name a type
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXicToXiPiPi.cxx:271:24: error: 'hfMlResponseDca' was not declared in this scope
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXicToXiPiPi.cxx:273:24: error: 'hfMlResponseKf' was not declared in this scope
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXicToXiPiPi.cxx:693:53: error: 'hfMlResponseDca' was not declared in this scope
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXicToXiPiPi.cxx:696:53: error: 'hfMlResponseKf' was not declared in this scope
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

alibuild commented Nov 4, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for 67dc6ae at 2026-11-05 00:21:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGHF/Core/HfMlResponseXicToXiPiPi.h:116:45: error: 'aod' has not been declared
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGHF/Core/HfMlResponseXicToXiPiPi.h:116:72: error: expected '>' before 'ReconstructionType'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXicToXiPiPi.cxx:95:17: error: '<expression error>' in namespace 'o2::analysis' does not name a type
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXicToXiPiPi.cxx:96:17: error: '<expression error>' in namespace 'o2::analysis' does not name a type
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXicToXiPiPi.cxx:271:24: error: 'hfMlResponseDca' was not declared in this scope
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXicToXiPiPi.cxx:273:24: error: 'hfMlResponseKf' was not declared in this scope
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXicToXiPiPi.cxx:693:53: error: 'hfMlResponseDca' was not declared in this scope
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXicToXiPiPi.cxx:696:53: error: 'hfMlResponseKf' was not declared in this scope
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

alibuild commented Nov 4, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for a4bba22 at 2026-11-05 00:53:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 4 errors and 15 warnings.'
Found 4 errors and 15 warnings.
++ [[ 4 -gt 0 ]]
++ cat /sw/BUILD/534015bdbf4ac484fd8ef17e7f87b9b8eb7609dc/O2Physics-code-check/errors.txt
PWGHF/Core/HfMlResponseXicToXiPiPi.h:25:1: error: included header map is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGHF/Core/HfMlResponseXicToXiPiPi.h:26:1: error: included header string is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGHF/Core/HfMlResponseXicToXiPiPi.h:27:1: error: included header vector is not used directly [misc-include-cleaner,-warnings-as-errors]
Tools/ML/model.h:25:10: error: 'onnxruntime_cxx_api.h' file not found [clang-diagnostic-error]
++ [[ 15 -gt 0 ]]
++ cat /sw/BUILD/534015bdbf4ac484fd8ef17e7f87b9b8eb7609dc/O2Physics-code-check/warnings.txt
PWGHF/Core/HfMlResponseXicToXiPiPi.h:40:9: warning: function-like macro 'CHECK_AND_FILL_VEC_XICTOXIPIPI_FULL' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage]
PWGHF/Core/HfMlResponseXicToXiPiPi.h:42:32: warning: macro argument should be enclosed in parentheses [bugprone-macro-parentheses]
PWGHF/Core/HfMlResponseXicToXiPiPi.h:48:9: warning: function-like macro 'CHECK_AND_FILL_VEC_XICTOXIPIPI' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage]
PWGHF/TableProducer/candidateSelectorXicToXiPiPi.cxx:57:52: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGHF/TableProducer/candidateSelectorXicToXiPiPi.cxx:85:56: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGHF/TableProducer/candidateSelectorXicToXiPiPi.cxx:125:10: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
PWGHF/TableProducer/candidateSelectorXicToXiPiPi.cxx:125:39: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
PWGHF/TableProducer/candidateSelectorXicToXiPiPi.cxx:125:69: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
PWGHF/TableProducer/candidateSelectorXicToXiPiPi.cxx:125:96: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
PWGHF/TableProducer/candidateSelectorXicToXiPiPi.cxx:150:5: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGHF/TableProducer/candidateSelectorXicToXiPiPi.cxx:621:32: warning: variable 'statusPidPi0' is not initialized [cppcoreguidelines-init-variables]
PWGHF/TableProducer/candidateSelectorXicToXiPiPi.cxx:622:32: warning: variable 'statusPidPi1' is not initialized [cppcoreguidelines-init-variables]
PWGHF/TableProducer/candidateSelectorXicToXiPiPi.cxx:623:32: warning: variable 'statusPidPiXi' is not initialized [cppcoreguidelines-init-variables]
PWGHF/TableProducer/candidateSelectorXicToXiPiPi.cxx:624:32: warning: variable 'statusPidPrLam' is not initialized [cppcoreguidelines-init-variables]
PWGHF/TableProducer/candidateSelectorXicToXiPiPi.cxx:625:32: warning: variable 'statusPidPiLam' is not initialized [cppcoreguidelines-init-variables]
++ [[ 4 -gt 0 ]]
++ exit 1
--

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner
@vkucera vkucera Awaiting requested review from vkucera vkucera is a code owner
@fcolamar fcolamar Awaiting requested review from fcolamar fcolamar is a code owner
@fgrosa fgrosa Awaiting requested review from fgrosa fgrosa is a code owner
@fcatalan92 fcatalan92 Awaiting requested review from fcatalan92 fcatalan92 is a code owner
@mfaggin mfaggin Awaiting requested review from mfaggin mfaggin is a code owner
@mmazzilli mmazzilli Awaiting requested review from mmazzilli mmazzilli is a code owner
@deepathoms deepathoms Awaiting requested review from deepathoms deepathoms is a code owner
@NicoleBastid NicoleBastid Awaiting requested review from NicoleBastid NicoleBastid is a code owner
@hahassan7 hahassan7 Awaiting requested review from hahassan7 hahassan7 is a code owner
@jpxrk jpxrk Awaiting requested review from jpxrk jpxrk is a code owner
@apalasciano apalasciano Awaiting requested review from apalasciano apalasciano is a code owner
@zhangbiao-phy zhangbiao-phy Awaiting requested review from zhangbiao-phy zhangbiao-phy is a code owner
@gluparel gluparel Awaiting requested review from gluparel gluparel is a code owner
@stefanopolitano stefanopolitano Awaiting requested review from stefanopolitano stefanopolitano is a code owner
@xinyepeng xinyepeng Awaiting requested review from xinyepeng xinyepeng is a code owner
@singhra1994 singhra1994 Awaiting requested review from singhra1994 singhra1994 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

pwghf PWG-HF

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lubynets @alibuild