Repository navigation
[PWGCF] Fix casts - #18385
Open
vkucera wants to merge 1 commit into
Open
[PWGCF] Fix casts#18385vkucera wants to merge 1 commit into
vkucera wants to merge 1 commit into
Conversation
|
O2 linter results: ❌ 0 errors, |
vkucera
force-pushed
the
cast-PWGCF
branch
3 times, most recently
from
October 26, 2026 14:33
48120c2 to
3e0cf62
Compare
Fixes C-style, redundant, wrong, and dangerous casts (found by Clang-Tidy and cpplint). - Remove redundant casts. (`readability-redundant-casting`) - Remove `const_cast`. (`cppcoreguidelines-pro-type-const-cast`) - Replace C-style casts with `static_cast`. (`google-readability-casting`, cpplint: `readability/casting`) - Replace unsafe C-style casts with `dynamic_cast`. (`cppcoreguidelines-pro-type-cstyle-cast`) - Replace `static_cast` in downcasts with `dynamic_cast`. (`cppcoreguidelines-pro-type-static-cast-downcast`) - Replace `reinterpret_cast` with `static_cast` or `dynamic_cast`. (`cppcoreguidelines-pro-type-reinterpret-cast`) - Replace two-step casting through `void*` with `reinterpret_cast`. (`bugprone-casting-through-void`)
vkucera
marked this pull request as ready for review
November 5, 2026 13:07
vkucera
requested review from
EmilGorm,
SwatiSaha-1997,
abilandz,
alibuild,
ariedel-cern,
dimihayl,
dsarkaralice,
fsii,
glromane,
isputows,
jaelpark,
jgrosseo,
lauraser,
lgraczykCern,
majanik,
prchakra,
sofiatomassini,
victor-gonzalez,
wenyaCern and
wrzesaCERN
as code owners
November 5, 2026 13:07
Collaborator
Author
|
Dear code owners, the PR is ready for review. |
jaelpark
approved these changes
Nov 5, 2026
EmilGorm
approved these changes
Nov 5, 2026
Collaborator
|
Error while checking build/O2Physics/code-check for bbe899b at 2026-11-05 17:33: Full log here. |
vkucera
enabled auto-merge (squash)
November 5, 2026 20:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes C-style, redundant, wrong, and dangerous casts (found by Clang-Tidy and cpplint).
readability-redundant-casting)const_cast. (cppcoreguidelines-pro-type-const-cast)static_cast. (google-readability-casting, cpplint:readability/casting)dynamic_cast. (cppcoreguidelines-pro-type-cstyle-cast)static_castin downcasts withdynamic_cast. (cppcoreguidelines-pro-type-static-cast-downcast)reinterpret_castwithstatic_castordynamic_cast. (cppcoreguidelines-pro-type-reinterpret-cast)void*withreinterpret_cast. (bugprone-casting-through-void)