[Common] Fix TPC side determination in VDrift correction - #17846
[Common] Fix TPC side determination in VDrift correction#17846matthias-kleiner wants to merge 3 commits into
Conversation
|
O2 linter results: ❌ 0 errors, |
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Hi @matthias-kleiner, thanks a lot for this fix! However, I was wondering what will happen with data for which the TPC side flags are not stored: this is relevant, since those were added only in February this year. Further, since they were added "adiabatically" by taking unused bits in the flags integer, older datasets will appear to have all tracks only in one side, and thus the fix will break in that situation. Is there perhaps some way in which the TPC side information could be inferred from other parameters that existed already before? For instance, a combination of tgl and the sign of Z (given we store tracks at the position of their innermost update?)... Sorry if I am overlooking something. Thanks again! |
The TPCSideA/TPCSideC flags were only added to the AOD format in February 2026, so datasets produced before that always have neither bit set. Detect CE-crossing tracks from the track's asymmetric time margins and otherwise infer the side from a cross-check of Z and tgl sign, per TPC domain expert guidance, instead of silently skipping the correction for all tracks in older datasets. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Hi @ddobrigk , |
3 participants
No description provided.