Skip to content

[PWGHF] Fix a typo in the selector - #17828

Merged
fgrosa merged 2 commits into
AliceO2Group:masterfrom
JaeYoonCHO:fixSelectorTypo
Sep 9, 2026
Merged

[PWGHF] Fix a typo in the selector#17828
fgrosa merged 2 commits into
AliceO2Group:masterfrom
JaeYoonCHO:fixSelectorTypo

Conversation

@JaeYoonCHO

Copy link
Copy Markdown
Contributor

This PR fixes a typo in candidateSelectorXicToXiPiPi.cxx, where the isSelectedTrackItsQuality check was originally applied only to the first pion. After this fix, isSelectedTrackItsQuality is applied to both pions.

@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

@github-actions github-actions Bot changed the title Fix a typo in the selector [PWGHF] Fix a typo in the selector Sep 8, 2026
@alibuild

alibuild commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 60b4843 at 2026-09-09 11:20:

## sw/BUILD/O2Physics-latest/log
2026-09-09T08:23:36.939+0200 [12877:140155401281152] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame]
2026-09-09T08:23:36.944+0200 [12877:140155401281152] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame
2026-09-09T08:26:49.056+0200 [12877:140155401281152] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "FindMissingBlobs()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame]
2026-09-09T08:27:11.352+0200 [12905:140296341249664] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame]
2026-09-09T08:27:11.352+0200 [12905:140296341249664] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame
2026-09-09T08:31:30.855+0200 [12905:140296341249664] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "FindMissingBlobs()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame]
2026-09-09T08:31:57.911+0200 [12951:140456576663168] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame]
2026-09-09T08:31:57.911+0200 [12951:140456576663168] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame
2026-09-09T08:36:05.558+0200 [12951:140456576663168] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "FindMissingBlobs()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame]
2026-09-09T08:36:27.747+0200 [12979:140604903104128] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame]
2026-09-09T08:36:27.747+0200 [12979:140604903104128] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame
2026-09-09T08:38:58.773+0200 [12979:140604903104128] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "FindMissingBlobs()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame]
2026-09-09T08:39:24.648+0200 [13017:140707246034560] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame]
2026-09-09T08:39:24.649+0200 [13017:140707246034560] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame


## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 7 errors and 3 warnings.'
Found 7 errors and 3 warnings.
++ [[ 7 -gt 0 ]]
++ cat /sw/BUILD/0aae3e8a04b874263607f649782b4af33c96ce5b/O2Physics-code-check/errors.txt
PWGHF/TableProducer/candidateSelectorXicToXiPiPi.cxx:57:52: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGHF/TableProducer/candidateSelectorXicToXiPiPi.cxx:85:56: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGHF/TableProducer/candidateSelectorXicToXiPiPi.cxx:607:32: error: variable 'statusPidPi0' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGHF/TableProducer/candidateSelectorXicToXiPiPi.cxx:608:32: error: variable 'statusPidPi1' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGHF/TableProducer/candidateSelectorXicToXiPiPi.cxx:609:32: error: variable 'statusPidPiXi' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGHF/TableProducer/candidateSelectorXicToXiPiPi.cxx:610:32: error: variable 'statusPidPrLam' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGHF/TableProducer/candidateSelectorXicToXiPiPi.cxx:611:32: error: variable 'statusPidPiLam' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
++ [[ 3 -gt 0 ]]
++ cat /sw/BUILD/0aae3e8a04b874263607f649782b4af33c96ce5b/O2Physics-code-check/warnings.txt
PWGHF/TableProducer/candidateSelectorXicToXiPiPi.cxx:124:10: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
PWGHF/TableProducer/candidateSelectorXicToXiPiPi.cxx:124:26: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
PWGHF/TableProducer/candidateSelectorXicToXiPiPi.cxx:145:5: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
++ [[ 7 -gt 0 ]]
++ exit 1
--

Full log here.

@fgrosa

fgrosa commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator

This PR fixes a typo in candidateSelectorXicToXiPiPi.cxx, where the isSelectedTrackItsQuality check was originally applied only to the first pion. After this fix, isSelectedTrackItsQuality is applied to both pions.

Thanks for spotting this! It should not have any effect anyway, as globalTracksWoDCA are selected in the creation of the HF derived data, but good to have it correct in the code.

@fgrosa
fgrosa merged commit 0861112 into AliceO2Group:master Sep 9, 2026
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pwghf PWG-HF

Development

Successfully merging this pull request may close these issues.

3 participants