[PWGJE] bjetTaggingGnn.cxx: Revised histogram fill code - #17824
Merged
Conversation
|
O2 linter results: ❌ 0 errors, |
github-actions
Bot
changed the title
choich08365
marked this pull request as ready for review
September 8, 2026 04:13
choich08365
requested review from
alibuild,
fjonasALICE,
jaimenorman,
mhemmer-cern and
nzardosh
as code owners
September 8, 2026 04:13
nzardosh
reviewed
Sep 9, 2026
| if (jetFlavor == JetTaggingSpecies::beauty) { | ||
| registry.fill(HIST("hSparse_bjets_sub"), jetpT, analysisJet.scoreML(), nTracks, massSV, weightEvt); | ||
| } else if (jetFlavor == JetTaggingSpecies::charm) { | ||
| registry.fill(HIST("hSparse_cjets_sub"), jetpT, analysisJet.scoreML(), nTracks, massSV, weightEvt); |
Collaborator
There was a problem hiding this comment.
none of the histograms with _sub have been added to the histogram registry
Contributor
Author
There was a problem hiding this comment.
Hi Nima, thanks for your comment. By the way, the function addDataDrivenHistograms in line 634 does add those histograms to the registry properly. The local test runs okay.
nzardosh
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PWGJE/Tasks/bjetTaggingGnn.cxxdoDataDrivenSV