Skip to content

[Common] Allow stopping before reaching partonic level in RecoDecay::getMother - #17816

Open
fchinu wants to merge 2 commits into
AliceO2Group:masterfrom
fchinu:fix_pdg_type
Open

[Common] Allow stopping before reaching partonic level in RecoDecay::getMother#17816
fchinu wants to merge 2 commits into
AliceO2Group:masterfrom
fchinu:fix_pdg_type

Conversation

@fchinu

@fchinu fchinu commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Until now, the getMother function would search up the full partonic shower to search for a mother, if depthMax was not set. With this PR I have added a new parameter to stop the search once the partonic level is reached.

@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 9 disabled

@github-actions github-actions Bot changed the title Allow stopping before reaching partonic level in RecoDecay::getMother [Common] Allow stopping before reaching partonic level in RecoDecay::getMother Sep 7, 2026
@fchinu
fchinu marked this pull request as draft September 7, 2026 16:28
@alibuild

alibuild commented Sep 7, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for d8200ca at 2026-09-07 18:35:

## sw/BUILD/O2Physics-latest/log
2026-09-07T17:49:31.140+0200 [2314:139714814742144] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Write()", last gRPC error was [14: recvmsg:Connection reset by peer]
2026-09-07T17:49:31.144+0200 [2314:139714814742144] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.UpdateActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-09-07T17:49:32.421+0200 [4253:140060493827712] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "FindMissingBlobs()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-09-07T17:49:33.199+0200 [4082:140677973700224] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "FindMissingBlobs()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-09-07T17:49:41.397+0200 [4504:140348434202240] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "FindMissingBlobs()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-09-07T17:49:49.440+0200 [4194:139724118314624] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "FindMissingBlobs()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-09-07T17:49:49.918+0200 [4725:140075537141376] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "FindMissingBlobs()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-09-07T17:49:37.261+0200 [4877:140367821102720] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-09-07T17:49:37.261+0200 [4877:140367821102720] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused
2026-09-07T17:49:36.422+0200 [4855:139687972339328] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-09-07T17:49:36.422+0200 [4855:139687972339328] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused
2026-09-07T17:49:59.861+0200 [4855:139687972339328] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "FindMissingBlobs()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv6:%5B::1%5D:8980: Failed to connect to remote host: Connection refused]
2026-09-07T17:49:34.333+0200 [4817:139843017879168] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-09-07T17:49:34.334+0200 [4817:139843017879168] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused
2026-09-07T17:49:53.428+0200 [4971:139636797591168] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-09-07T17:49:53.428+0200 [4971:139636797591168] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused
2026-09-07T17:49:43.369+0200 [4912:139991804333696] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-09-07T17:49:43.369+0200 [4912:139991804333696] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused
2026-09-07T17:49:51.949+0200 [4944:140341154471552] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-09-07T17:49:51.949+0200 [4944:140341154471552] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused
c++: fatal error: Killed signal terminated program cc1plus
ninja: build stopped: subcommand failed.

Full log here.

@fchinu
fchinu marked this pull request as ready for review September 9, 2026 10:02
@alibuild

alibuild commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for d080b88 at 2026-09-09 15:06:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 1 errors and 4 warnings.'
Found 1 errors and 4 warnings.
++ [[ 1 -gt 0 ]]
++ cat /sw/BUILD/521b9626efcc385dae7600f58f4854842eba2627/O2Physics-code-check/errors.txt
Common/Core/RecoDecay.h:926:5: error: uninitialized record type: 'arrPdgDaughters' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
++ [[ 4 -gt 0 ]]
++ cat /sw/BUILD/521b9626efcc385dae7600f58f4854842eba2627/O2Physics-code-check/warnings.txt
Common/Core/RecoDecay.h:596:28: warning: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty]
Common/Core/RecoDecay.h:623:15: warning: do not use 'else' after 'break' [readability-else-after-return]
Common/Core/RecoDecay.h:1059:12: warning: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty]
Common/Core/RecoDecay.h:1157:12: warning: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty]
++ [[ 1 -gt 0 ]]
++ exit 1
--

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants