Skip to content

[PWGJE] Adding reflection signal from MC and updating jet matching process - #17750

Merged
nzardosh merged 13 commits into
AliceO2Group:masterfrom
Rajdeep-nandi:master
Sep 9, 2026
Merged

[PWGJE] Adding reflection signal from MC and updating jet matching process#17750
nzardosh merged 13 commits into
AliceO2Group:masterfrom
Rajdeep-nandi:master

Conversation

@Rajdeep-nandi

Copy link
Copy Markdown
Contributor

This pull request includes :

  1. Adding the reflection template
  2. Adding Angularity in the sparse histogram
  3. Modified the matching process function

@github-actions github-actions Bot added the pwgje label Sep 3, 2026
@github-actions github-actions Bot changed the title Adding the reflection [PWGJE] Adding the reflection Sep 3, 2026
Rajdeep-nandi added a commit to Rajdeep-nandi/O2Physics that referenced this pull request Sep 3, 2026
Please consider the following formatting changes to AliceO2Group#17750
@vkucera

vkucera commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

@Rajdeep-nandi The PR title is too vague. Please add info about the location.

@Rajdeep-nandi Rajdeep-nandi changed the title [PWGJE] Adding the reflection [PWGJE] Adding reflection signal from MC and updating jet matching process Sep 3, 2026
@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 4 warnings, 🔕 0 disabled

@alibuild

alibuild commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 80065c8 at 2026-09-04 12:32:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 5 errors and 6 warnings.'
Found 5 errors and 6 warnings.
++ [[ 5 -gt 0 ]]
++ cat /sw/BUILD/1bb08e8f5ef53ba6f3255545f1e0f16fdc4f36a5/O2Physics-code-check/errors.txt
PWGJE/Tasks/jetHFAngularity.cxx:21:1: error: included header JetSubstructure.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGJE/Tasks/jetHFAngularity.cxx:51:11: error: no header providing "int8_t" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGJE/Tasks/jetHFAngularity.cxx:52:18: error: unused variable 'kCandSelFlagD0bar' [clang-diagnostic-unused-const-variable,-warnings-as-errors]
PWGJE/Tasks/jetHFAngularity.cxx:257:3: error: no header providing "o2::framework::Produces" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGJE/Tasks/jetHFAngularity.cxx:611:14: error: variable 'm' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
++ [[ 6 -gt 0 ]]
++ cat /sw/BUILD/1bb08e8f5ef53ba6f3255545f1e0f16fdc4f36a5/O2Physics-code-check/warnings.txt
PWGJE/Tasks/jetHFAngularity.cxx:1019:15: warning: boolean expression can be simplified by DeMorgan's theorem [readability-simplify-boolean-expr]
PWGJE/Tasks/jetHFAngularity.cxx:1065:21: warning: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty]
PWGJE/Tasks/jetHFAngularity.cxx:1107:17: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
PWGJE/Tasks/jetHFAngularity.cxx:1108:17: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
PWGJE/Tasks/jetHFAngularity.cxx:1109:17: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
PWGJE/Tasks/jetHFAngularity.cxx:1216:13: warning: boolean expression can be simplified by DeMorgan's theorem [readability-simplify-boolean-expr]
++ [[ 5 -gt 0 ]]
++ exit 1
--

Full log here.

@alibuild

alibuild commented Sep 6, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 206670e at 2026-09-09 08:33:

## sw/BUILD/O2Physics-latest/log
c++: fatal error: Killed signal terminated program cc1plus
ninja: build stopped: subcommand failed.

Full log here.

Comment thread PWGJE/Tasks/jetHFAngularity.cxx
Comment thread PWGJE/Tasks/jetHFAngularity.cxx
@Rajdeep-nandi

Rajdeep-nandi commented Sep 9, 2026

Copy link
Copy Markdown
Contributor Author

Dear @nzardosh all checks have been passed
will you kindly check and approve it?
I have also removed unwanted header files and resolved the code-check errors as well as the warnings
Thank you

@nzardosh
nzardosh merged commit eca977a into AliceO2Group:master Sep 9, 2026
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

5 participants