[PWGHF] [xic0omegac0] Updated candidate creator & candidate selector#16042
[PWGHF] [xic0omegac0] Updated candidate creator & candidate selector#16042jinhyunni wants to merge 6 commits intoAliceO2Group:masterfrom
Conversation
|
O2 linter results: ❌ 0 errors, |
| int pdgIdOfV0DauPos, pdgIdOfV0DauNeg, pdgIdOfBach, pdgIdOfCharmBach; | ||
| int pdgIdOfAntiV0DauPos, pdgIdOfAntiV0DauNeg, pdgIdOfAntiBach, pdgIdOfAntiCharmBach; | ||
| int pdgIdOfV0, pdgIdOfCascade, pdgIdOfCharmBaryon; | ||
|
|
||
| // Track PID - Used in DCAFitter | ||
| int trackPidOfCascade; | ||
|
|
||
| // Mass of daughter tracks & V0s & cascades & charm baryons; | ||
| float massOfV0DauPos, massOfV0DauNeg, massOfBach, massOfCharmBach; | ||
| float massOfV0, massOfCascade, massOfCharmBaryon; | ||
| float massOfV0DauPos, massOfV0DauNeg, massOfCharmBach; | ||
| float massOfV0, massOfCascade; |
There was a problem hiding this comment.
Always initialise in declaration.
There was a problem hiding this comment.
Hi @vkucera,
They are set to be initialized within init function.
Do they still needed to be initialized at the moment of declaration?
There was a problem hiding this comment.
Yes, it can be just with {}, but it should always be there.
There was a problem hiding this comment.
I wasn't aware of that issue.
Thanks for letting me know!
I've added commit to incorporate your comment.
Hi @jinhyunni, why you remove |
Hi @zhangbiao-phy. |
Hi @jinhyunni, I see your point. maybe we can try to address this at a later stage, when you subscribe to the table. You can refer to the solution used for the 3-prong case here: O2Physics/PWGHF/TableProducer/treeCreatorLcToPKPi.cxx Lines 1165 to 1166 in 482efe6 continue here, the final tree will become very large. This issue will be even more pronounced in Pb–Pb analyses.
|
Thanks for your thoughtful comment on this update. |
Please consider the following formatting changes to AliceO2Group#16042
|
And sorry for accidentaly closing this PR without appropriate consultion. |
candidateCreatorXic0Omegac0Qa:
massOfBach,massOfCharmBaryoncandidateSelectorToXiPiQa:
continuestatement inside candidate loop