[PWGCF] updated code for mixing hadrons with mixed phi from diff events#16029
Open
prottayCMT wants to merge 2 commits intoAliceO2Group:masterfrom
Open
[PWGCF] updated code for mixing hadrons with mixed phi from diff events#16029prottayCMT wants to merge 2 commits intoAliceO2Group:masterfrom
prottayCMT wants to merge 2 commits intoAliceO2Group:masterfrom
Conversation
added 2 commits
April 29, 2026 19:05
… mixed phi also removing commented lines
prottayCMT
requested review from
alibuild,
jaelpark,
jgrosseo,
otonvd,
shouqiye and
victor-gonzalez
as code owners
|
O2 linter results: ❌ 3 errors, |
github-actions
Bot
changed the title
Collaborator
Author
|
@jaelpark could you please approve |
jaelpark
reviewed
Apr 29, 2026
| } | ||
| } | ||
|
|
||
| if (rejectMixedPhiProngEventsNow && cfgRejectMixedPhiProngEvents) { |
Collaborator
There was a problem hiding this comment.
Why is rejectMixedPhiProngEventsNow needed? Why not just check if target is mixed and doprocessMixed2ProngDerivedMixedPhi true?
Contributor
There was a problem hiding this comment.
I agree that if possible we should get rid of that variable, or if really needed make it a template variable and not a member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.