[Common] Migrate track propagation#16007
Conversation
|
O2 linter results: ❌ 7 errors, |
|
Error while checking build/O2Physics/o2 for 979fb29 at 2026-04-28 18:19: Full log here. |
|
Doesn't seem like Claude delivered. :-D |
979fb29 to
d3c69b4
Compare
|
It needs some change in O2 first. |
|
Error while checking build/O2Physics/o2 for d3c69b4 at 2026-04-28 21:02: Full log here. |
|
Error while checking build/O2Physics/o2 for 8c91c95 at 2026-04-28 22:21: Full log here. |
|
|
||
| namespace o2::aod | ||
| { | ||
| namespace glo |
There was a problem hiding this comment.
Should we use a namespace which contains ccdb, like ccdbGlo?
There was a problem hiding this comment.
yes, or even just o2::aod::ccdb. Glo could be the name of the table (or something like that...)
| @@ -0,0 +1,358 @@ | |||
| // Copyright 2019-2020 CERN and copyright holders of ALICE O2. | |||
There was a problem hiding this comment.
I would remove this file from the PR as the original task is deprecated
|
|
||
| // Declarative CCDB path overrides (replace grpmagPath / mVtxPath in StandardCCDBLoaderConfigurables) | ||
| // Option names: "ccdb:fGRPMagField" and "ccdb:fMeanVertex" respectively. | ||
| ConfigurableCCDBPath<o2::aod::glo::GRPMagField> grpmagPath; |
There was a problem hiding this comment.
How does one add the default here (following our Mattermost discussion)?
There was a problem hiding this comment.
Why not simply using the value in the table (https://github.com/AliceO2Group/O2Physics/pull/16007/changes#diff-0510885f66743b174b2f0688713d8b351c5ea30865e7fcedac2b1654321f7169R54) for the default? The idea would be that you need to declare a ConfigurableCCDBPath only if you really need to override it.
There was a problem hiding this comment.
I could also move the default specification in ConfigurableCCDBPath declaration, but then that means that for each table we need to have the configurable declaration in every task, regardless of whether it is actually used.
There was a problem hiding this comment.
As said, we should get the default into the json for Hyperloop. Do you have a produced json from this task which you can send me on Mattermost?
There was a problem hiding this comment.
What happens when two tasks have a ConfigurableCCDBPath<o2::aod::glo::GRPMagField> grpmagPath and we add both to a train?
There was a problem hiding this comment.
I am adapting the code in O2 to complain in that case.
There was a problem hiding this comment.
I mean, if more than one provide a different value for the override.
- Add a central table for common CCDB Objects
8c91c95 to
df493bd
Compare
|
Error while checking build/O2Physics/o2 for df493bd at 2026-04-29 10:04: Full log here. |
No description provided.