[PWGJE] Implemented suggestions from comments on previous pull request.#16002
Closed
Lolle2001 wants to merge 2 commits intoAliceO2Group:masterfrom
Closed
[PWGJE] Implemented suggestions from comments on previous pull request.#16002Lolle2001 wants to merge 2 commits intoAliceO2Group:masterfrom
Lolle2001 wants to merge 2 commits intoAliceO2Group:masterfrom
Conversation
Lolle2001
requested review from
alibuild,
fjonasALICE,
maoyx,
mfasDa,
mhemmer-cern,
nzardosh and
raymondEhlers
as code owners
|
O2 linter results: ❌ 1 errors, |
github-actions
Bot
changed the title
- Updated the includes according to the O2 guidelines. - Removed registry as an argument in the `analyse` methods.
Collaborator
|
@Lolle2001 Please avoid fragmenting PRs. Update the existing one instead. #15914 |
Author
Author
Hi @vkucera, could you reopen this PR please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
analysemethods.