Skip to content

[PWGUD] fix efficiency and cuts#16001

Draft
miedema-11 wants to merge 3 commits intoAliceO2Group:masterfrom
miedema-11:master
Draft

[PWGUD] fix efficiency and cuts#16001
miedema-11 wants to merge 3 commits intoAliceO2Group:masterfrom
miedema-11:master

Conversation

@miedema-11
Copy link
Copy Markdown
Contributor

sorry, there is something wrong when I make PR, I rebased the local repo and make a new one to solve conflicts

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 28, 2026

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

@github-actions github-actions Bot changed the title fix efficiency and cuts [PWGUD] fix efficiency and cuts Apr 28, 2026
@alibuild
Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 967f799 at 2026-04-28 16:24:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGUD/Tasks/flowCorrelationsUpc.cxx:378:78: error: unused parameter 'phi' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGUD/Tasks/flowCorrelationsUpc.cxx:378:89: error: unused parameter 'eta' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGUD/Tasks/flowCorrelationsUpc.cxx:378:110: error: unused parameter 'vtxz' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGUD/Tasks/flowCorrelationsUpc.cxx:394:60: error: unused parameter 'runNumber' [-Werror=unused-parameter]
ninja: build stopped: subcommand failed.

Full log here.

@vkucera vkucera marked this pull request as draft April 28, 2026 16:43
@miedema-11 miedema-11 marked this pull request as ready for review April 29, 2026 04:48
amatyja
amatyja previously approved these changes Apr 29, 2026
@amatyja amatyja enabled auto-merge (squash) April 29, 2026 06:35
@alibuild
Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 05f4434 at 2026-04-29 08:50:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGUD/Tasks/flowCorrelationsUpc.cxx:382:61: error: 'pt' was not declared in this scope
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGUD/Tasks/flowCorrelationsUpc.cxx:449:37: error: no matching function for call to 'FlowCorrelationsUpc::setCurrentParticleWeights(float&, float&, double&, double&, double&, float&)'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGUD/Tasks/flowCorrelationsUpc.cxx:559:14: error: no matching function for call to 'FlowCorrelationsUpc::fillYield(const o2::soa::Filtered<o2::soa::Join<o2::soa::Table<o2::aod::Hash<2657540000>, o2::aod::Hash<3135302176>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<1410905594>, o2::aod::Hash<446486427>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<807122599>, o2::aod::Hash<1454186550>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<3917278297>, o2::aod::Hash<1825850698>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<4164916329>, o2::aod::Hash<3202835261>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<97380440>, o2::aod::Hash<2457333663>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<3047285986>, o2::aod::Hash<2462257971>, o2::aod::Hash<2286545062> > > >::iterator&, const FlowCorrelationsUpc::UdTracksFull&, int&, float&)'
ninja: build stopped: subcommand failed.

Full log here.

@vkucera vkucera marked this pull request as draft April 29, 2026 07:41
auto-merge was automatically disabled April 29, 2026 07:41

Pull request was converted to draft

@vkucera
Copy link
Copy Markdown
Collaborator

vkucera commented Apr 29, 2026

@miedema-11 Can you please explain your workflow? I don't understand how you can create a PR which doesn't compile on any system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

4 participants