Skip to content

[PWGUD] fix efficiency & cuts#15989

Closed
miedema-11 wants to merge 13 commits intoAliceO2Group:masterfrom
miedema-11:master
Closed

[PWGUD] fix efficiency & cuts#15989
miedema-11 wants to merge 13 commits intoAliceO2Group:masterfrom
miedema-11:master

Conversation

@miedema-11
Copy link
Copy Markdown
Contributor

@miedema-11 miedema-11 commented Apr 28, 2026

No description provided.

@github-actions github-actions Bot added the pwgud label Apr 28, 2026
@github-actions github-actions Bot changed the title fix efficiency & cuts [PWGUD] fix efficiency & cuts Apr 28, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 28, 2026 •
edited
Loading

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

rolavick
rolavick previously approved these changes Apr 28, 2026
View reviewed changes
@rolavick rolavick enabled auto-merge (squash) April 28, 2026 08:38
@alibuild
Copy link
Copy Markdown
Collaborator

alibuild commented Apr 28, 2026

Error while checking build/O2Physics/o2 for d67242c at 2026-04-28 10:40:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGUD/Tasks/flowCorrelationsUpc.cxx:219:35: error: redeclaration of 'o2::framework::Service<o2::ccdb::BasicCCDBManager> FlowCorrelationsUpc::ccdb'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGUD/Tasks/flowCorrelationsUpc.cxx:220:105: error: redeclaration of 'o2::framework::Configurable<std::__cxx11::basic_string<char> > FlowCorrelationsUpc::ccdbUrl'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGUD/Tasks/flowCorrelationsUpc.cxx:222:55: error: redeclaration of 'o2::framework::OutputObj<GFWWeights> FlowCorrelationsUpc::fWeights'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGUD/Tasks/flowCorrelationsUpc.cxx:223:59: error: redeclaration of 'o2::framework::OutputObj<GFWWeights> FlowCorrelationsUpc::fWeightsMc'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGUD/Tasks/flowCorrelationsUpc.cxx:225:20: error: redeclaration of 'TAxis* FlowCorrelationsUpc::fPtAxis'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGUD/Tasks/flowCorrelationsUpc.cxx:226:24: error: redeclaration of 'int FlowCorrelationsUpc::lastRunNumber'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGUD/Tasks/flowCorrelationsUpc.cxx:227:20: error: redeclaration of 'std::vector<int> FlowCorrelationsUpc::runNumbers'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGUD/Tasks/flowCorrelationsUpc.cxx:229:22: error: redeclaration of 'std::vector<float> FlowCorrelationsUpc::efficiencyCache'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGUD/Tasks/flowCorrelationsUpc.cxx:399:78: error: unused parameter 'phi' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGUD/Tasks/flowCorrelationsUpc.cxx:399:89: error: unused parameter 'eta' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGUD/Tasks/flowCorrelationsUpc.cxx:399:110: error: unused parameter 'vtxz' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGUD/Tasks/flowCorrelationsUpc.cxx:415:60: error: unused parameter 'runNumber' [-Werror=unused-parameter]
ninja: build stopped: subcommand failed.

Full log here.

auto-merge was automatically disabled April 28, 2026 13:34

Head branch was pushed to by a user without write access

vkucera
vkucera requested changes Apr 28, 2026
View reviewed changes
Comment thread PWGUD/Tasks/flowCorrelationsUpc.cxx Outdated
Copy link
Copy Markdown
Collaborator

@vkucera vkucera Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only English, please.

Comment thread PWGUD/Tasks/flowCorrelationsUpc.cxx
Comment on lines 43 to 67
Copy link
Copy Markdown
Collaborator

@vkucera vkucera Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did you come up with this list?

@miedema-11 miedema-11 closed this Apr 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkucera vkucera vkucera requested changes

@rolavick rolavick rolavick left review comments

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@amatyja amatyja Awaiting requested review from amatyja amatyja is a code owner

Assignees

No one assigned

Labels

pwgud

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@miedema-11 @alibuild @rolavick @vkucera