Skip to content

[Common,PWGHF] Add reduced q vectors for Event-shape Engineering#15636

Draft
Marcellocosti wants to merge 13 commits intoAliceO2Group:masterfrom
Marcellocosti:red_q_vecs
Draft

[Common,PWGHF] Add reduced q vectors for Event-shape Engineering#15636
Marcellocosti wants to merge 13 commits intoAliceO2Group:masterfrom
Marcellocosti:red_q_vecs

Conversation

@Marcellocosti
Copy link
Copy Markdown
Contributor

@Marcellocosti Marcellocosti commented Apr 2, 2026

No description provided.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 2, 2026 •
edited
Loading

O2 linter results: ❌ 19 errors, ⚠️ 46 warnings, 🔕 0 disabled

@github-actions github-actions Bot changed the title [Common, PWGHF] Add reduced q vectors for Event-shape Engineering [Common,PWGHF] Add reduced q vectors for Event-shape Engineering Apr 2, 2026
@alibuild alibuild mentioned this pull request Apr 2, 2026
Merged
Marcellocosti added a commit to Marcellocosti/O2Physics that referenced this pull request Apr 2, 2026
@Marcellocosti
Merge pull request #61 from alibuild/alibot-cleanup-15636
c84f1c8 
Please consider the following formatting changes to AliceO2Group#15636
@Marcellocosti Marcellocosti marked this pull request as ready for review April 2, 2026 19:30
Marcellocosti added a commit to Marcellocosti/O2Physics that referenced this pull request Apr 7, 2026
@Marcellocosti
Merge pull request #62 from alibuild/alibot-cleanup-15636
8abcdc2 
Please consider the following formatting changes to AliceO2Group#15636
@Marcellocosti
Copy link
Copy Markdown
Contributor Author

Marcellocosti commented Apr 7, 2026

Thanks @vkucera, I have implemented your suggestions!

stefanopolitano
stefanopolitano previously approved these changes Apr 7, 2026
View reviewed changes
@alibuild
Copy link
Copy Markdown
Collaborator

alibuild commented Apr 7, 2026

Error while checking build/O2Physics/o2 for 8abcdc2 at 2026-04-07 11:54:

No log files found

Full log here.

@alibuild alibuild mentioned this pull request Apr 7, 2026
Merged
Marcellocosti added a commit to Marcellocosti/O2Physics that referenced this pull request Apr 7, 2026
@Marcellocosti
Merge pull request #63 from alibuild/alibot-cleanup-15636
1ed6984 
Please consider the following formatting changes to AliceO2Group#15636
stefanopolitano
stefanopolitano previously approved these changes Apr 7, 2026
View reviewed changes
@alibuild
Copy link
Copy Markdown
Collaborator

alibuild commented Apr 10, 2026

Error while checking build/O2Physics/o2 for 1ed6984 at 2026-04-10 18:18:

## sw/BUILD/O2Physics-latest/log
c++: fatal error: Killed signal terminated program cc1plus
ninja: build stopped: subcommand failed.

Full log here.

@Marcellocosti Marcellocosti marked this pull request as draft April 27, 2026 16:59
@alibuild alibuild mentioned this pull request Apr 28, 2026
Merged
@Marcellocosti
Merge pull request #65 from alibuild/alibot-cleanup-15636
1dcac3f 
Please consider the following formatting changes to AliceO2Group#15636
@Marcellocosti
Copy link
Copy Markdown
Contributor Author

Marcellocosti commented Apr 28, 2026

Hi @stefanopolitano, @MaximVirta, @jikim1290,

Following our conversation of last week, I have updated the PR.

I refactored the task by introducing 3 different functions, CalQvec, NormalizeQvec, CorrectQvec. Now the multiplicity normalization is removed from CalQvec, that runs once both for SP and EsE q-vectors. Then the functions NormalizeQvec and CorrectQvec are called separately to obtain the SP and EsE q-vectors, for which now dedicated CCDB objects can be uploaded as we agreed.

Now the PR is drafted since there are still some debug prints, which I will remove once the implementation looks fine to you. I could test locally that the changes are backward compatible and one obtains the same SP q-vectors, apart from the cases where the amplitude of the FIT detector is null, where changes are only due to modifications of the default values (sign in 999).

Thanks in advance for your feedback!

stefanopolitano
stefanopolitano approved these changes Apr 29, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@stefanopolitano stefanopolitano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Marcellocosti ! Thanks for the development. I think this looks fine and coincide with what was agreed with the Qvector experts

vkucera
vkucera reviewed Apr 30, 2026
View reviewed changes
Comment thread Common/TableProducer/qVectorsTable.cxx
qVectorTPCall(IsCalibrated, qvecReTPCallSp.at(0), qvecImTPCallSp.at(0), qvecAmp[kTPCall], TrkTPCallLabel);

// Debug prints of values after corrections
std::cout << "[CORRECTED] FT0C, Re: " << qvecReFT0CSp.at(0) << ", Im: " << qvecImFT0CSp.at(0) << std::endl;
Copy link
Copy Markdown
Collaborator

@vkucera vkucera Apr 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope

@vkucera
Copy link
Copy Markdown
Collaborator

vkucera commented Apr 30, 2026

@Marcellocosti Please fix the errors and warnings introduced by your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkucera vkucera vkucera left review comments

@stefanopolitano stefanopolitano stefanopolitano approved these changes

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@fcolamar fcolamar Awaiting requested review from fcolamar fcolamar is a code owner

@fgrosa fgrosa Awaiting requested review from fgrosa fgrosa is a code owner

@fcatalan92 fcatalan92 Awaiting requested review from fcatalan92 fcatalan92 is a code owner

@mfaggin mfaggin Awaiting requested review from mfaggin mfaggin is a code owner

@mmazzilli mmazzilli Awaiting requested review from mmazzilli mmazzilli is a code owner

@deepathoms deepathoms Awaiting requested review from deepathoms deepathoms is a code owner

@NicoleBastid NicoleBastid Awaiting requested review from NicoleBastid NicoleBastid is a code owner

@hahassan7 hahassan7 Awaiting requested review from hahassan7 hahassan7 is a code owner

@jpxrk jpxrk Awaiting requested review from jpxrk jpxrk is a code owner

@apalasciano apalasciano Awaiting requested review from apalasciano apalasciano is a code owner

@zhangbiao-phy zhangbiao-phy Awaiting requested review from zhangbiao-phy zhangbiao-phy is a code owner

@gluparel gluparel Awaiting requested review from gluparel gluparel is a code owner

@singhra1994 singhra1994 Awaiting requested review from singhra1994 singhra1994 is a code owner

@jgrosseo jgrosseo Awaiting requested review from jgrosseo jgrosseo is a code owner

@iarsene iarsene Awaiting requested review from iarsene iarsene is a code owner

@ktf ktf Awaiting requested review from ktf ktf is a code owner

@ddobrigk ddobrigk Awaiting requested review from ddobrigk ddobrigk is a code owner

@dsekihat dsekihat Awaiting requested review from dsekihat dsekihat is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

common datamodel pwghf PWG-HF

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Marcellocosti @alibuild @vkucera @stefanopolitano