Repository navigation
ALICE3: TRK/FT3 digitizer response matrix on the heap, not the stack - #16033
Merged
Merged
Conversation
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
f3sch
requested review from
arossi81,
fcolamar,
fgrosa,
fprino,
mconcas,
mcoquet642,
njacazio and
shahor02
as code owners
November 2, 2026 10:13
njacazio
approved these changes
Nov 3, 2026
njacazio
enabled auto-merge (squash)
November 3, 2026 09:04
Collaborator
Author
|
@shahor02 could we merge this or do you see any problems? |
shahor02
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move response matrix allocation away from the stack and to the heap to be reused across hits of the same event.
For ALICE3 very low-pT QED electrons passing at oblique angles one can run into the stack overflow limit.
Ported to ITS2/3&MFT since the keeping the buffer on the heap for synchronicity and maybe to avoid the same problem (although I have not seen it yet); in any case the code change is straightforward.