ITS: fix ITSTrackROF outpu#15328
Merged
shahor02 merged 2 commits intoAliceO2Group:devfrom Apr 27, 2026
Merged
Conversation
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
shahor02
previously approved these changes
Apr 27, 2026
Collaborator
shahor02
left a comment
There was a problem hiding this comment.
Thanks @f3sch
Could you also add
diff --git a/Detectors/GlobalTracking/src/MatchTPCITS.cxx b/Detectors/GlobalTracking/src/MatchTPCITS.cxx
index 29c45edd6e..1457790c7c 100644
--- a/Detectors/GlobalTracking/src/MatchTPCITS.cxx
+++ b/Detectors/GlobalTracking/src/MatchTPCITS.cxx
@@ -709,7 +709,7 @@ bool MatchTPCITS::prepareITSData()
mITSWork.reserve(mITSTracksArray.size());
// total N ITS clusters in TF
- const auto& lastClROF = mITSClusterROFRec[nROFs - 1];
+ const auto& lastClROF = mITSClusterROFRec.back();
int nITSClus = lastClROF.getFirstEntry() + lastClROF.getNEntries();
mABClusterLinkIndex.resize(nITSClus, MinusOne);
for (int sec = o2::constants::math::NSectors; sec--;) {
to make the matcher internally consistent.
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
Collaborator
Author
|
sure done |
shahor02
approved these changes
Apr 27, 2026
Collaborator
shahor02
left a comment
There was a problem hiding this comment.
Tested locally, merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes crash if there were clusters but the ITS tracking did not find anything, the tpcits matching still wants ITSTrackROF to be correct, otherwise as reported by @catalinristea and @shahor02:
now:
Also checked that ITSTrackROF in case something was found, is still the same as before.