Skip to content

ITS3: implement staggering #15310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
f3sch wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

ITS3: implement staggering #15310

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a8b31f7
ITSMFT: ITS3: reuse clusterizer
f3sch Apr 22, 2026
be04421
ITS3: adapt staggering
f3sch Apr 22, 2026
06000aa
ITS: fix truth seeding mode
f3sch Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions Detectors/ITSMFT/ITS/tracking/include/ITStracking/TrackingInterface.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,14 +34,14 @@ namespace o2::its
{
class ITSTrackingInterface
{
public:
static constexpr int NLayers{7};
using VertexerN = Vertexer<NLayers>;
using VertexerTraitsN = VertexerTraits<NLayers>;
using TrackerN = Tracker<NLayers>;
using TrackerTraitsN = TrackerTraits<NLayers>;
using TimeFrameN = TimeFrame<NLayers>;

public:
ITSTrackingInterface(bool isMC,
bool doStag,
int trgType,
Expand Down Expand Up @@ -80,6 +80,7 @@ class ITSTrackingInterface
TimeFrameN* mTimeFrame = nullptr;

protected:
virtual void requestTopologyDictionary(framework::ProcessingContext& pc);
virtual void loadROF(gsl::span<const itsmft::ROFRecord>& trackROFspan,
gsl::span<const itsmft::CompClusterExt> clusters,
gsl::span<const unsigned char>::iterator& pattIt,
Expand All @@ -98,7 +99,7 @@ class ITSTrackingInterface
const o2::itsmft::TopologyDictionary* mDict = nullptr;
std::unique_ptr<TrackerN> mTracker = nullptr;
std::unique_ptr<VertexerN> mVertexer = nullptr;
const o2::dataformats::MeanVertexObject* mMeanVertex;
const o2::dataformats::MeanVertexObject* mMeanVertex{};
std::shared_ptr<BoundedMemoryResource> mMemoryPool;
std::shared_ptr<tbb::task_arena> mTaskArena;
};
Expand Down
7 changes: 6 additions & 1 deletion Detectors/ITSMFT/ITS/tracking/src/TrackingInterface.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,7 +362,7 @@ void ITSTrackingInterface::updateTimeDependentParams(framework::ProcessingContex
}
if (!initOnceDone) { // this params need to be queried only once
initOnceDone = true;
pc.inputs().get<o2::itsmft::TopologyDictionary*>("itscldict"); // just to trigger the finaliseCCDB
requestTopologyDictionary(pc);
pc.inputs().get<o2::itsmft::DPLAlpideParam<o2::detectors::DetID::ITS>*>("itsalppar");
if (pc.inputs().getPos("itsTGeo") >= 0) {
pc.inputs().get<o2::its::GeometryTGeo*>("itsTGeo");
Expand Down Expand Up @@ -474,6 +474,11 @@ void ITSTrackingInterface::setTraitsFromProvider(VertexerTraitsN* vertexerTraits
mVertexer->setMemoryPool(mMemoryPool);
}

void ITSTrackingInterface::requestTopologyDictionary(framework::ProcessingContext& pc)
{
pc.inputs().get<o2::itsmft::TopologyDictionary*>("itscldict"); // just to trigger the finaliseCCDB
}

void ITSTrackingInterface::loadROF(gsl::span<const itsmft::ROFRecord>& trackROFspan,
gsl::span<const itsmft::CompClusterExt> clusters,
gsl::span<const unsigned char>::iterator& pattIt,
Expand Down
3 changes: 2 additions & 1 deletion Detectors/ITSMFT/ITS/tracking/src/Vertexer.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,6 @@ float Vertexer<NLayers>::clustersToVertices(LogFunc logger)

// update LUT with all currently found vertices so in second iteration we can check vertPerROFThreshold
sortVertices();
mTimeFrame->updateROFVertexLookupTable();
}
} catch (const BoundedMemoryResource::MemoryLimitExceeded& err) {
handleException(err);
Expand Down Expand Up @@ -126,6 +125,8 @@ void Vertexer<NLayers>::sortVertices()
}
mc.swap(sortedMC);
}
// update LUT after sorting
mTimeFrame->updateROFVertexLookupTable();
}

template <int NLayers>
Expand Down
2 changes: 0 additions & 2 deletions Detectors/ITSMFT/common/reconstruction/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ o2_target_root_dictionary(
include/ITSMFTReconstruction/DigitPixelReader.h
include/ITSMFTReconstruction/RawPixelReader.h
include/ITSMFTReconstruction/PixelData.h
include/ITSMFTReconstruction/Clusterer.h
include/ITSMFTReconstruction/ClustererParam.h
include/ITSMFTReconstruction/BuildTopologyDictionary.h
include/ITSMFTReconstruction/LookUp.h
Expand All @@ -67,4 +66,3 @@ if (OpenMP_CXX_FOUND)
target_compile_definitions(${targetName} PRIVATE WITH_OPENMP)
target_link_libraries(${targetName} PRIVATE OpenMP::OpenMP_CXX)
endif()

Loading