Skip to content

350: [factory] Canary: prove cloud dispatch end to end — regression test for describeControlPlaneError redaction #461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
agent-relay-code wants to merge 1 commit into
base: main
Choose a base branch
from
Open

350: [factory] Canary: prove cloud dispatch end to end — regression test for describeControlPlaneError redaction #461

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions src/fleet/control-plane-circuit.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,42 @@ import {
DEFAULT_FLEET_ROSTER_TIMEOUT_MS,
FleetControlPlaneCircuit,
FleetControlPlaneCircuitOpenError,
describeControlPlaneError,
guardFleetControlPlane,
isFleetControlPlaneFailure,
} from './control-plane-circuit'

const roster: RosterEntry = { agents: [], nodes: [] }

describe('describeControlPlaneError', () => {
it.each([
'request failed for https://relay.invalid/events?credential=example-secret',
'authorization failed for Bearer example.invalid.token',
'could not connect to postgres://example-user:example-password@db.invalid/factory',
])('redacts transport text from an Error message', (message) => {
const error = new Error(message)
error.name = 'FleetTransportError'

expect(describeControlPlaneError(error)).toBe('FleetTransportError')
})

it('appends a well-formed error code', () => {
const error = Object.assign(new Error('transport details'), { code: 'ECONNREFUSED_42' })

expect(describeControlPlaneError(error)).toBe('Error (ECONNREFUSED_42)')
})

it.each([
'connection_refused',
'CONNECTION-REFUSED',
'A'.repeat(81),
])('drops a malformed error code', (code) => {
const error = Object.assign(new Error('transport details'), { code })

expect(describeControlPlaneError(error)).toBe('Error')
})
})

describe('FleetControlPlaneCircuit', () => {
afterEach(() => {
vi.useRealTimers()
Expand Down