fix(claude-relay-plugin): align plugin identity and drop the legacy engine pin - #91
fix(claude-relay-plugin): align plugin identity and drop the legacy engine pin#91willwashburn wants to merge 2 commits into
Conversation
|
Warning Review limit reached
Next review available in: 59 minutes Limit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?Wait for the limit to reset, then comment An organization admin can change what happens after included review limits in Billing. How do review limits work?CodeRabbit enforces per-developer PR review limits within each organization. For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (8)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 198cbaa974
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
All reported issues were addressed across 4 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
…ngine pin Four pieces of the plugin's configuration disagreed with each other. **Engine URL.** `.mcp.json` pinned `RELAY_BASE_URL` to `https://gateway.relaycast.dev`, a legacy host. Every default in both repos is `https://cast.agentrelay.com` (relaycast's `client.ts` and `relay.ts`; relay's `observer-source.ts` and `integration.ts`), and the skills document that host too. Plugin users were being pointed at a different engine than everything else. Removed the pin outright rather than hardcoding the right host, so the plugin follows the SDK default wherever that moves next. **Plugin name.** `plugin.json` declared `agent-relay` while the directory, the marketplace entry, and `package.json` all say `claude-relay-plugin`. Aligned `plugin.json` to the other three rather than renaming three things to match one. **Repository.** The marketplace entry claimed the plugin lives in `AgentWorkforce/relay`, but its own `source.url` and `plugin.json` both point at `AgentWorkforce/skills` — which is where it is. **README.** Told users `/plugin marketplace add Agentworkforce/relay`. The marketplace manifest only exists in this repo, so that command cannot resolve. Now names the right repo and adds the install step. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Jmke9G9s7ftrN49opNmdx1
Review caught that removing only the MCP server's `RELAY_BASE_URL` pin splits the plugin across two engines. The `env` block applies to the MCP subprocess alone, so the separately-launched hooks kept their own `gateway.relaycast.dev` fallback: on a fresh install the MCP server would talk to `cast.agentrelay.com` while `post-tool-inbox.sh` and `stop-inbox.js` queried the legacy host with a token minted by the new one — silently missing every message and defeating both inbox polling and the stop guard. That is the same config drift this PR set out to fix. Updates every remaining default to the SDK's (`cast.agentrelay.com`): `stop-inbox.ts` and its compiled `stop-inbox.js`, `post-tool-inbox.sh`, and the two places the plugin README documents the default. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Jmke9G9s7ftrN49opNmdx1
198cbaa to
ea95adc
Compare
2 participants
Summary
Four pieces of the plugin's configuration disagreed with each other. Each is small; together they mean a fresh install points at the wrong engine and the documented install command doesn't resolve.
Engine URL
.mcp.jsonpinnedRELAY_BASE_URLtohttps://gateway.relaycast.dev. Every default in both repos ishttps://cast.agentrelay.com:relaycast/packages/sdk-typescript/src/client.ts:172relaycast/packages/sdk-typescript/src/relay.ts:316,368relay/packages/sdk/src/messaging/observer-source.ts:272relay/packages/cli/src/cli/commands/integration.ts:509and the skills in this repo document
cast.agentrelay.comtoo. Plugin users were being sent to a different engine than everything else in the product.relaycast.devhosts are also what relaycast-cloud's legacy strangler router is migrating away from.Removed the pin rather than swapping in the correct host, so the plugin follows the SDK default wherever that moves next instead of needing another fix.
Plugin name
plugin.jsondeclaredagent-relay; the directory, the marketplace entry, andpackage.jsonall sayclaude-relay-plugin. Alignedplugin.jsonto the other three rather than renaming three things to match one.Worth a second opinion:
agent-relayis arguably the nicer user-facing name, and going that direction instead would mean renaming the directory, the marketplace entry, andpackage.json— and would make the installclaude-relay-plugin@agent-relayread asagent-relay@agent-relay. I took the low-risk direction; say the word if you'd rather have the other.Repository
The marketplace entry claimed the plugin lives in
AgentWorkforce/relay, while its ownsource.urlandplugin.jsonboth point atAgentWorkforce/skills— which is where it actually is.README
Told users to run
/plugin marketplace add Agentworkforce/relay.marketplace.jsonexists only in this repo (findacross both confirms it), so that command cannot resolve. Now names the right repo and adds the missing install step.Part of a series from a review of the Agent Relay skills and plugins.
Test Plan
marketplace.json,plugin.json,.mcp.json,package.json,prpm.json)plugin.jsonname,package.jsonname, andsource.pathbasename are allclaude-relay-plugin; both repository fields andsource.urlpoint atAgentWorkforce/skillscast.agentrelay.comis the default in both SDKs by grepping the relaycast and relay sourcesmarketplace.jsonexists only in this repo, not inrelay/plugin marketplace add+/plugin installagainst the updated manifest — not run; needs a live Claude Code install. Worth doing before merge since it exercises the renamed plugin identityScreenshots
n/a
Generated by Claude Code