Repository navigation
Conversation
Osayi-ANL
requested changes
Oct 6, 2026
Osayi-ANL
left a comment
Collaborator
There was a problem hiding this comment.
Please check out the memory-estimate readout update I added in commit c22acee. It makes the estimate compact, keeps it in muted grey italics, and bolds the calculated memory sizes. If you like the change, please re-request my review and I’ll approve.
Osayi-ANL
force-pushed
the
change/workflow-add-missing-defaults-report
branch
from
October 21, 2026 20:52
b67d776 to
fd62d35
Compare
…ting consumers with high-memory buffers
…ler prompt, and the associator and collector prompts count images only since their queues never hold HKL data
Osayi-ANL
changed the base branch from
change/workflow-add-missing-defaults-report
to
main
October 30, 2026 17:53
Osayi-ANL
force-pushed
the
add/workflow-memory-estimates
branch
from
October 30, 2026 17:53
c22acee to
a8fabe0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #185 — review/merge that one first; this diff shows only this PR's change.
Summary
Test plan
pytest tests/unitpasses;ruff check src/dashpva/cleantest_workflow_memory_estimates.py🤖 Generated with Claude Code