Repository navigation
Fix associator codec label and collector startup without a tty - #178
Merged
Merged
Conversation
…ed codec field assignment was silently lost fix: collector passes -dc so pvapy's curses screen does not abort it without a tty
Osayi-ANL
approved these changes
Oct 6, 2026
Osayi-ANL
left a comment
Osayi-ANL
left a comment
Collaborator
There was a problem hiding this comment.
Looks good. Ruff passed; 815 unit tests passed. One local EPICS/ophyd test segfaulted, but CI is green, so it is non-blocking.
Collaborator
|
The non-blocking local crash occurred in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pvObject['codec']['name']edits a copy and is lost, so compressed frames went out labelled uncompressed; assign the whole field.-dclike the other consumers — under Popen pvapy's curses screen aborts withsetupterm: could not find terminal.Test plan
pytest tests/unitpasses;ruff check src/dashpva/clean🤖 Generated with Claude Code