fix: reword foreground notification to not expose internals - #223
Merged
Conversation
The persistent notification said "ActivityWatch Server" / "Server and sync running in background", leaking the internal server detail and claiming sync is running even though sync is disabled by default. Use a neutral "ActivityWatch" / "Running in the background" wording, and rename the notification channel accordingly.
Greptile SummaryThe PR updates the foreground-service notification and notification-channel wording to avoid exposing implementation details or implying that optional sync is active.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains. Important Files Changed
Reviews (2): Last reviewed commit: "fix: reword foreground notification to n..." | Re-trigger Greptile |
Member
Author
|
@greptileai review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The persistent foreground-service notification said "ActivityWatch Server" / "Server and sync running in background" — leaking the internal "server" detail and implying sync is configured/running, even though sync is off by default.
Changes:
ActivityWatch/Running in the backgroundBackground tracking/Keeps ActivityWatch running in the backgroundNo behavioral changes; the channel keeps the same ID so existing user preferences (e.g. having minimized/silenced it) are preserved.
Reported by @ErikBjare while testing 0.14.0b1 (versionCode 39).