Skip to content

Refactor conditions for preview release triggers #2550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
UnschooledGamer wants to merge 5 commits into
base: main
Choose a base branch
from
+13 −8
Open

Refactor conditions for preview release triggers #2550

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3ed7986
Refactor conditions for preview release triggers
UnschooledGamer Jul 28, 2026
3b8de2a
Refactor conditions for on-demand preview releases
UnschooledGamer Jul 28, 2026
562ed42
Update nightly-build.yml with additional comments
UnschooledGamer Jul 28, 2026
9e5ae91
Clarify PR workflow execution and approval process
UnschooledGamer Jul 28, 2026
66b0cb3
Update .github/workflows/on-demand-preview-releases-PR.yml
UnschooledGamer Jul 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/nightly-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
# Implement to use environment secrets someday, At the moment GH Actions doesn't support those in reusable workflows (ref: https://github.com/actions/runner/issues/1490)
# at least that's what I found.
# This workflow executes PR Code when triggered from PR via workflow_call,
# MUST approve the PR code BEFORE triggering this workflow.

name: Nightly Build

Expand Down Expand Up @@ -101,6 +103,7 @@ jobs:
fetch-depth: 0 # Required for tags
persist-credentials: false
ref: ${{ (inputs.is_PR && inputs.PR_NUMBER) && github.event.pull_request.head.sha || '' }}
allow-unsafe-pr-checkout: ${{ !!(inputs.is_PR && inputs.PR_NUMBER && github.event.pull_request.head.sha) }}

- name: Setup Java
uses: actions/setup-java@v5
Expand Down Expand Up @@ -204,4 +207,4 @@ jobs:
echo "| Normal APK Artifact Name | ${{ steps.meta.outputs.normal_artifact_name }} |" >> $GITHUB_STEP_SUMMARY
echo "| F-Droid APK Artifact Name | ${{ steps.meta.outputs.fdroid_artifact_name || 'N/A' }} |" >> $GITHUB_STEP_SUMMARY
echo "| Normal APK Artifact SHA256 | ${{ steps.sha256.outputs.normal_apk_sha256 }} |" >> $GITHUB_STEP_SUMMARY
echo "| F-Droid APK Artifact SHA256 | ${{ steps.sha256.outputs.fdroid_apk_sha256 || 'N/A' }} |" >> $GITHUB_STEP_SUMMARY
echo "| F-Droid APK Artifact SHA256 | ${{ steps.sha256.outputs.fdroid_apk_sha256 || 'N/A' }} |" >> $GITHUB_STEP_SUMMARY
16 changes: 9 additions & 7 deletions .github/workflows/on-demand-preview-releases-PR.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
name: On Demand Preview Releases for PR
# avoids paths like .md, and anything in .github folder
on:
# This workflow executes PR Code by checkout later
# MUST approve the PR Code BEFORE using this workflow on PRs.
# Uses this trigger to keep up-to-date execution of the workflow (triggers from Default Branch)
pull_request_target:
paths-ignore:
- '!*.md'
Expand All @@ -23,13 +26,12 @@ jobs:
contents: read
pull-requests: write
issues: write
if: |
github.event.pull_request.draft == false
&& (github.repository_owner == 'Acode-Foundation'
&& (!contains(github.event.pull_request.labels.*.name, 'DO NOT PREVIEW RELEASE')
&& (contains(github.event.pull_request.labels.*.name, 'Bypass check - PREVIEW RELEASE')
|| contains(github.event.pull_request.labels.*.name, 'CI: RUN ON-DEMAND PREVIEW RELEASES')
))
if: >-
github.event.pull_request.draft == false &&
github.repository_owner == 'Acode-Foundation' &&
(!contains(github.event.pull_request.labels.*.name, 'DO NOT PREVIEW RELEASE') &&
(github.event.action == 'labeled' && github.event.label.name == 'CI: RUN ON-DEMAND PREVIEW RELEASES' ||
github.event.action == 'synchronize' && contains(github.event.pull_request.labels.*.name, 'Bypass check - PREVIEW RELEASE'))
)

runs-on: ubuntu-latest
Expand Down