Repository navigation
fix: SG-45651: Fix crash with -debug profile on the Vulkan and Metal views - #1491
Merged
bernie-laberge merged 1 commit intoNov 10, 2026
Conversation
bernie-laberge
marked this pull request as ready for review
November 10, 2026 01:53
bernie-laberge
requested review from
cedrik-fuoco-adsk and
eloisebrosseau
as code owners
November 10, 2026 01:53
eloisebrosseau
approved these changes
Nov 10, 2026
…views Open a profiling sample around each render in VulkanWindow::render() and MetalView::render(), as GLWindow::paintGL() does (AcademySoftwareFoundation#1447). Without it, Session::render() reads the current sample from an empty vector and RV crashes on the first frame when 10-bit presentation is enabled. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Bernard Laberge <bernard.laberge@autodesk.com>
bernie-laberge
force-pushed
the
SG-45651-fix-debug-profile-vulkan-metal
branch
from
November 10, 2026 22:29
c20c4ac to
ff516e8
Compare
bernie-laberge
merged commit Nov 10, 2026
6fdc9ba
into
AcademySoftwareFoundation:main
18 of 19 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issues
No GitHub issue. Tracked internally as SG-45651.
Summarize your change.
Fix the crash when RV is started with
-debug profileand 10-bit presentation is enabled (Vulkan on Linux/Windows, Metal on macOS).Describe the reason for the change.
Session::render()writes into the current profiling sample, which the viewport must open before each render. #1447 restored this inGLWindow::paintGL(), butVulkanWindow::render()andMetalView::render()never open one, so RV readsback()from an empty vector and crashes on the first frame.Describe what you have tested and on which operating system.
macOS, 10-bit (Metal):
rv -debug profile <media>no longer crashes, and the.rvproffile is written on exit.Add a list of changes, and note any that might need special attention during the review.
VulkanWindow::render()andMetalView::render(): begin the profiling sample beforesession->render(), record render end, and record swap end after the frame is presented, asGLWindowdoes.If possible, provide screenshots.
N/A
🤖 Generated with Claude Code