Repository navigation
Refresh the collection versions tab and tighten two checks - #46
Merged
Merged
Conversation
The add and remove actions of an ansible repository called the list query without using its answer, so the tab kept showing the repository version it was loaded with, and a failed extra request ended as an unhandled rejection. They now follow the task of the modify request and load the repository page again once it is done; a failed task is reported, and a task that is still running or whose status cannot be read raises a warning. Both dialogs now disable their confirm button while the request runs, so a double click no longer starts two tasks.
A script or stylesheet named by index.html outside a js or css folder was left out of the total without a word, so a change of the output layout could shrink the measured initial load while the check stayed green. Such an asset now ends the check with exit status 2.
The installed plugin list of the remote suites kept a failed status/ read for the life of the worker, so one network error failed every later test of that worker with the same unrelated error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scripts/bundle-size.mjsexits 2 when index.html names a script or stylesheet outside a js or css folder, instead of leaving it out of the total.installedPlugins()no longer keeps a failedstatus/read for the life of the worker.Tests: unit tests for the reload, a failed task and a double click on both dialogs; the bundle-size tests expect the error; the remote spec now expects the tab to refresh by itself.