Skip to content

Fix buffer initialization condition in USART_Server.c - #52

Merged
MiloradCvjetkovic merged 1 commit into
ARM-software:mainfrom
karthikkbs05:patch-1
Aug 21, 2026
Merged

Fix buffer initialization condition in USART_Server.c#52
MiloradCvjetkovic merged 1 commit into
ARM-software:mainfrom
karthikkbs05:patch-1

Conversation

@karthikkbs05

Copy link
Copy Markdown
Contributor

Change logical OR to logical AND for buffer initialization check.

Change logical OR to logical AND for buffer initialization check.
@karthikkbs05

Copy link
Copy Markdown
Contributor Author

Line 265: Changed || to && so initialization fails if either buffer allocation fails
Line 267: Fixed ptr_usart_xfer_buf_rx to ptr_usart_xfer_buf_tx (was clearing RX buffer twice)
Seemed like a bug!

@MiloradCvjetkovic MiloradCvjetkovic left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MiloradCvjetkovic
MiloradCvjetkovic merged commit 3214e3b into ARM-software:main Aug 21, 2026
1 check passed
@MiloradCvjetkovic

Copy link
Copy Markdown
Collaborator

Thank you @karthikkbs05 for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants