Skip to content

Remove unused _cleanup_on_retry helper in elastic manager. #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
copybara-service wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove unused _cleanup_on_retry helper in elastic manager. #362

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions pathwaysutils/elastic/manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,20 +214,6 @@ def scale_by_active_slices(self, x: int | float) -> int | float:
else:
raise ValueError(f"Unsupported type: {type(x)=}")

def _cleanup_on_retry(self):
"""Cleans up JAX caches and traces on retry."""
try:
_logger.debug("Cleaning up any ongoing traces")
jax.profiler.stop_trace()
except (RuntimeError, ValueError):
_logger.debug("No ongoing traces to clean up")
except Exception: # pylint: disable=broad-exception-caught
_logger.exception("Error cleaning up ongoing traces")

jax.clear_caches()
for array in jax.live_arrays():
array.delete()

def _check_inactive_slices(self) -> None:
"""Checks inactive slices and updates available_inactive_slices."""
if not self.inactive_slice_indices:
Expand Down
Loading