Skip to content

Update expected threads to fix maxtext profiler failures - #799

Closed
hengtaoguo wants to merge 1 commit into
mainfrom
hengtaoguo-profiler
Closed

hengtaoguo wants to merge 1 commit into
mainfrom
hengtaoguo-profiler

Conversation

@hengtaoguo

Copy link
Copy Markdown
Collaborator

Update the expected_threads to match with the profiler tests.

Recently, the package tensorboard-plugin-profile was updated from version 2.15.1 to 2.15.2. This update may have caused the maxtext-profiling tests to fail since July 15, 2024. This PR updates the expected_threads name to match with the new updates. Local airflow tests passed with success in "run_models."

@hengtaoguo
hengtaoguo requested a review from gobbleturk as a code owner July 25, 2024 23:14
@google-cla

google-cla Bot commented Jul 25, 2024

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@hengtaoguo hengtaoguo closed this Jul 25, 2024
@hengtaoguo hengtaoguo reopened this Jul 25, 2024
@hengtaoguo hengtaoguo closed this Jul 25, 2024
@hengtaoguo hengtaoguo reopened this Jul 25, 2024
@hengtaoguo hengtaoguo closed this Jul 25, 2024
@hengtaoguo
hengtaoguo deleted the hengtaoguo-profiler branch July 25, 2024 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant