Skip to content

Tag RC Docker images during build and run CI, E2E, and performance tests in parallel - #5811

Merged
copybara-service[bot] merged 1 commit into
mainfrom
rc_release_v2
Oct 19, 2026
Merged

copybara-service[bot] merged 1 commit into
mainfrom
rc_release_v2

Conversation

@SurbhiJainUSC

@SurbhiJainUSC SurbhiJainUSC commented Oct 17, 2026 •

Copy link
Copy Markdown
Collaborator

Description

This PR updates the Release Candidate Pipeline (rc_release.yml) so that RC tags (:${MAXTEXT_SHA} and :latest-rc) are applied directly during the image build/promotion step, allowing CI tests (run_ci_tests), Airflow E2E functional tests (run_e2e_tests), and performance tests to run in parallel once the RC images are built. Also passes a consistent image_date (YYYY-MM-DD) from caller workflows into build_and_push_docker_image.yml.

Changes

  • [.github/workflows/build_and_push_docker_image.yml]
    • Accept image_date as a workflow input instead of computing date +%Y-%m-%d at the end of promote_and_tag, ensuring consistent date tags across matrix builds.
    • Add an optional is_rc boolean input (default false) to tag Release Candidate images with :latest-rc tag.
  • [.github/workflows/rc_release.yml]
    • Pass image_date: ${{ needs.get_maxtext_sha.outputs.rc_date }} (YYYY-MM-DD) and is_rc: true to build_release_candidate_images.
    • Remove the separate tag_release_candidate_images job since RC tagging now happens in build_and_push_docker_image.yml.
    • Run run_ci_tests and run_e2e_tests in parallel directly after build_release_candidate_images, and pass image_tag: ${{ needs.get_maxtext_sha.outputs.short_sha }} to run_ci_tests.yml so passing images are tagged with :verified-ci-${SHA_RC}.

Tests

https://github.com/AI-Hypercomputer/maxtext/actions/runs/38986301715 - pushes RC image in maxtext-test-images repository, skips CI tests and E2E tests.

https://github.com/AI-Hypercomputer/maxtext/actions/runs/39297931486 - pushes RC image in maxtext-images repository, runs CI tests and triggers E2E tests

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation.

@gemini-code-assist

Copy link
Copy Markdown

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@codecov

codecov Bot commented Oct 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@SurbhiJainUSC SurbhiJainUSC added skip-ci-tests Add this label to the PR to skip running CI tests and removed skip-ci-tests Add this label to the PR to skip running CI tests labels Oct 19, 2026
@copybara-service
copybara-service Bot merged commit 9f09e06 into main Oct 19, 2026
97 checks passed
@copybara-service
copybara-service Bot deleted the rc_release_v2 branch October 19, 2026 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants