Repository navigation
Tag RC Docker images during build and run CI, E2E, and performance tests in parallel - #5811
Merged
Merged
Conversation
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
SurbhiJainUSC
force-pushed
the
rc_release_v2
branch
from
October 19, 2026 18:06
1ed249c to
1920590
Compare
SurbhiJainUSC
marked this pull request as ready for review
October 19, 2026 18:06
SurbhiJainUSC
requested review from
bvandermoon,
darisoy,
gobbleturk,
huytransformer,
igorts-git,
khatwanimohit,
parambole,
richjames0,
shralex and
xibinliu
as code owners
October 19, 2026 18:06
bvandermoon
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the Release Candidate Pipeline (
rc_release.yml) so that RC tags (:${MAXTEXT_SHA}and:latest-rc) are applied directly during the image build/promotion step, allowing CI tests (run_ci_tests), Airflow E2E functional tests (run_e2e_tests), and performance tests to run in parallel once the RC images are built. Also passes a consistentimage_date(YYYY-MM-DD) from caller workflows intobuild_and_push_docker_image.yml.Changes
.github/workflows/build_and_push_docker_image.yml]image_dateas a workflow input instead of computingdate +%Y-%m-%dat the end ofpromote_and_tag, ensuring consistent date tags across matrix builds.is_rcboolean input (defaultfalse) to tag Release Candidate images with:latest-rctag..github/workflows/rc_release.yml]image_date: ${{ needs.get_maxtext_sha.outputs.rc_date }}(YYYY-MM-DD) andis_rc: truetobuild_release_candidate_images.tag_release_candidate_imagesjob since RC tagging now happens inbuild_and_push_docker_image.yml.run_ci_testsandrun_e2e_testsin parallel directly afterbuild_release_candidate_images, and passimage_tag: ${{ needs.get_maxtext_sha.outputs.short_sha }}torun_ci_tests.ymlso passing images are tagged with:verified-ci-${SHA_RC}.Tests
https://github.com/AI-Hypercomputer/maxtext/actions/runs/38986301715 - pushes RC image in
maxtext-test-imagesrepository, skips CI tests and E2E tests.https://github.com/AI-Hypercomputer/maxtext/actions/runs/39297931486 - pushes RC image in
maxtext-imagesrepository, runs CI tests and triggers E2E testsChecklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.