Skip to content

Add optional model-bringup PR cleanup guidance - #5781

Open
hengtaoguo wants to merge 1 commit into
mainfrom
hengtaoguo-skill
Open

hengtaoguo wants to merge 1 commit into
mainfrom
hengtaoguo-skill

Conversation

@hengtaoguo

@hengtaoguo hengtaoguo commented Oct 15, 2026 •

Copy link
Copy Markdown
Collaborator

Description

Add an explicit opt-in cleanup phase, disabled by default, with a concise reference covering temporary tool removal, full-diff formatting, debugging cleanup, pylint fixes, and model-specific atomic PR splits. Delegate stack upload mechanics to upstream maxtext-pr-upload.

Tests

Using this subskill to split an example PR #5803 / #5804.

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds documentation and guidelines for large PR cleanups and atomic splits during model bring-up, introducing a new reference document pr_cleanup.md and updating SKILL.md. Feedback on the changes includes a correction to the documented Python line length limit, suggesting it be updated from 122 to 125 characters to match the repository's authoritative pylintrc configuration.

Comment thread .agents/skills/model-bringup/references/pr_cleanup.md Outdated

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants