Repository navigation
Add optional model-bringup PR cleanup guidance - #5781
Open
hengtaoguo wants to merge 1 commit into
Open
hengtaoguo wants to merge 1 commit into
hengtaoguo wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Code Review
This pull request adds documentation and guidelines for large PR cleanups and atomic splits during model bring-up, introducing a new reference document pr_cleanup.md and updating SKILL.md. Feedback on the changes includes a correction to the documented Python line length limit, suggesting it be updated from 122 to 125 characters to match the repository's authoritative pylintrc configuration.
hengtaoguo
marked this pull request as ready for review
October 16, 2026 23:29
hengtaoguo
requested review from
A9isha,
NuojCheng,
RissyRan,
SurbhiJainUSC,
abhinavclemson,
aireenmei,
bvandermoon,
darisoy,
dipannita08,
gagika,
gobbleturk,
huytransformer,
igorts-git,
jiangjy1982,
khatwanimohit,
richjames0,
shralex,
shuningjin,
vipannalla and
xibinliu
as code owners
October 16, 2026 23:29
abhinavclemson
approved these changes
Oct 16, 2026
hengtaoguo
force-pushed
the
hengtaoguo-skill
branch
from
October 19, 2026 21:42
74e0d0a to
9d16ea4
Compare
hengtaoguo
force-pushed
the
hengtaoguo-skill
branch
from
October 19, 2026 21:46
ca459b1 to
acb2ed6
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add an explicit opt-in cleanup phase, disabled by default, with a concise reference covering temporary tool removal, full-diff formatting, debugging cleanup, pylint fixes, and model-specific atomic PR splits. Delegate stack upload mechanics to upstream
maxtext-pr-upload.Tests
Using this subskill to split an example PR #5803 / #5804.
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.