Repository navigation
[NNX] Delete Linen 3/5: collapse dispatch in inference (maxengine, kvcache, vLLM, LoRA) - #4359
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
ecnal-cienet
force-pushed
the
feat/nnx-del-linen-3-inference
branch
2 times, most recently
from
July 7, 2026 21:00
cb9c0d0 to
fbe1484
Compare
ecnal-cienet
force-pushed
the
feat/nnx-del-linen-3-inference
branch
7 times, most recently
from
July 21, 2026 18:55
b514961 to
6a2b270
Compare
ecnal-cienet
force-pushed
the
feat/nnx-del-linen-3-inference
branch
6 times, most recently
from
July 29, 2026 14:48
2a26f98 to
e1a43f7
Compare
ecnal-cienet
force-pushed
the
feat/nnx-del-linen-3-inference
branch
4 times, most recently
from
August 20, 2026 21:38
dab8d49 to
5890a05
Compare
ecnal-cienet
force-pushed
the
feat/nnx-del-linen-3-inference
branch
4 times, most recently
from
August 31, 2026 21:18
527888e to
9306d86
Compare
ecnal-cienet
force-pushed
the
feat/nnx-del-linen-3-inference
branch
2 times, most recently
from
September 8, 2026 22:19
5c100eb to
3e451bd
Compare
ecnal-cienet
changed the base branch from
main
to
feat/nnx-del-linen-2-trainers
September 8, 2026 23:06
ecnal-cienet
force-pushed
the
feat/nnx-del-linen-2-trainers
branch
from
September 8, 2026 23:10
6d7511d to
9ef95e4
Compare
ecnal-cienet
requested review from
A9isha,
Lumosis,
NuojCheng,
RissyRan,
SurbhiJainUSC,
abhinavclemson,
aireenmei,
bvandermoon,
darisoy,
dipannita08,
gagika,
gobbleturk,
hengtaoguo,
huytransformer,
igorts-git,
jiangjy1982,
khatwanimohit,
richjames0,
shralex,
shuningjin and
xibinliu
as code owners
September 9, 2026 17:48
bvandermoon
approved these changes
Sep 9, 2026
…kvcache, vLLM, LoRA)
ecnal-cienet
force-pushed
the
feat/nnx-del-linen-3-inference
branch
from
September 9, 2026 19:43
e60b030 to
9208fbd
Compare
hengtaoguo
approved these changes
Sep 9, 2026
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NNX Migration Route Map
pure_nnxflag,init_state_fn,TrainStateNNX, NNX utils. Linen workflow unchanged. (PR NNX migration prep (1/N): pure_nnx flag and init_state_fn scaffolding #3427)get_abstract_state_nnx,get_named_sharding_nnx,set_named_sharding_nnx,get_partition_spec_nnx,get_mesh_from_config. (PR NNX migration prep (2/N): NNX utils and sharding utilities #3470)TrainStateNNX, model creation, gradient accumulation, checkpointing, and training loop dispatch. (PR NNX migration prep (3/N): TrainState, model creation, and end-to-end training loop #3500)9.5. ✅ NNX + AQT in MaxEngine + serve-mode reload + gpt3 prefill fix. (PR [NNX] NNX migration prep (9.5/N): NNX + AQT in MaxEngine + serve-mode reload + gpt3 prefill fix #3844)
custom_vjpfor NNX.True; regenerate sharding goldens; flip back integration-testpure_nnx=Falseannotations. (PR [NNX] NNX migration (11/N): set pure_nnx / enable_nnx / pure_nnx_decoder defaults to True #3526)12.1. ✅ Collapse Linen dispatch in utils / quantization / checkpointing / sharding. (PR [NNX] Delete Linen 1/5: collapse dispatch in utils, quantization, checkpointing, sharding #4357)
12.2. ✅ Collapse Linen dispatch in trainers (pre-train, DiLoCo, GRPO); regenerate the NNX DPO golden. (PR [NNX] Delete Linen 2/5: collapse dispatch in trainers (pre-train, DiLoCo, GRPO) #4358)
12.3. 🔄 [This PR] Collapse Linen dispatch in inference / serving —
maxengine.py,kvcache.py,vllm_decode.py,lora_utils.py+ tests. Also drops theenable_nnx/pure_nnx_decoderentriesvllm_decode.pyforwarded into the nested vLLMmaxtext_config. Stacks on 12.2.12.4. ❌ Delete the Linen decoder/attention/embedding layers +
*_as_linenmodel wrappers.12.5. ❌ Remove the
pure_nnx/enable_nnx/pure_nnx_decoderconfig flags.Description
Third of the stacked "Delete Linen" series (see 1/5). Collapses the Linen dispatch in the inference and serving path:
maxengine.py,kvcache.py,vllm_decode.py, andlora_utils.py, with their tests updated. This also drops theenable_nnx/pure_nnx_decoderentries thatvllm_decode.pyforwarded into the nested vLLMmaxtext_config, since that nested MaxText now defaults to NNX.Serving already ran the NNX path by default, so this is dead-branch removal with no behavior change. Base branch is
feat/nnx-del-linen-2-trainers. ~8 files, +189 / −648.Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.