Repository navigation
[Deepseek V4] Add caching support and verify decoding - #4176
Closed
Rohan-Bierneni wants to merge 1 commit into
Closed
Rohan-Bierneni wants to merge 1 commit into
Rohan-Bierneni wants to merge 1 commit into
Conversation
Rohan-Bierneni
requested review from
Lumosis,
NicoGrande,
NuojCheng,
RissyRan,
bvandermoon,
gagika,
gobbleturk,
gpolovets1,
jiangjy1982,
jrplatin,
mailvijayasingh,
mitalisi,
parambole,
patemotter,
richjames0,
shralex,
shuningjin,
suexu1025 and
vipannalla
as code owners
June 16, 2026 17:27
Rohan-Bierneni
requested review from
A9isha,
SurbhiJainUSC,
abhinavclemson,
aireenmei,
darisoy,
dipannita08,
hengtaoguo,
igorts-git and
khatwanimohit
as code owners
June 18, 2026 16:57
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Integrate v4 attention file with maxengine Write unit test for testing caching in compressed_attention and make fixes to get test passing
Rohan-Bierneni
force-pushed
the
rbierneni-v4-decoding
branch
from
June 18, 2026 17:02
250c9ce to
4dc04bc
Compare
Collaborator
Author
|
Created separate pr and merging there: #4444 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PR add caching support to attention_compressed.py and verifies v4 has decoding support with the maxengine/jetstream backend
If the change fixes a bug or a Github issue, please include a link, e.g.,:
FIXES: b/123456
Tests
Synthetic data cmd: https://paste.googleplex.com/5435406769324032
Output: https://paste.googleplex.com/6295276670287872
Decode.py should pass (In progress)
cmd:
output:
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.