Add weight for ragged gather kernel and enable fan out in bwd ragged sort#4166
Open
NuojCheng wants to merge 1 commit into
Open
Add weight for ragged gather kernel and enable fan out in bwd ragged sort#4166NuojCheng wants to merge 1 commit into
NuojCheng wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
ee734a4 to
2de0a9c
Compare
2de0a9c to
9172c06
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the usage of
ragged_gatherkernel under_ring_ragged_unsort_bwd. Previously, this kernel was applied in non-fan-out way, since the backward pass the unsort requires weight balance, while the ragged gather kernel did not support. This PR adds this support and enable a fan-out style of this kernel, successfully avoid materializing the full padded-shape tensor in fp32.FIXES: b/522526813
Tests
ragged_buffer_factor=3.0: xprofChecklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.