Repository navigation
Support Custom MaxText model (with vLLM engine) in RL rollouts. - #2778
Merged
copybara-service[bot] merged 1 commit intoDec 20, 2025
Merged
Conversation
NicoGrande
force-pushed
the
nicogrande/maxtext-vllm-rl-integration
branch
3 times, most recently
from
December 5, 2025 19:26
bc49da1 to
9b5677c
Compare
NicoGrande
marked this pull request as ready for review
December 5, 2025 21:55
NicoGrande
requested review from
A9isha,
NuojCheng,
RissyRan,
SurbhiJainUSC,
aireenmei,
bvandermoon,
gagika,
gobbleturk,
hengtaoguo,
jiangjy1982,
khatwanimohit,
parambole,
richjames0,
shralex,
shuningjin,
suexu1025 and
vipannalla
as code owners
December 5, 2025 21:55
NicoGrande
force-pushed
the
nicogrande/maxtext-vllm-rl-integration
branch
8 times, most recently
from
December 16, 2025 20:19
d82bf6f to
28835d7
Compare
NicoGrande
force-pushed
the
nicogrande/maxtext-vllm-rl-integration
branch
4 times, most recently
from
December 18, 2025 00:46
472355f to
9631581
Compare
A9isha
reviewed
Dec 18, 2025
NicoGrande
force-pushed
the
nicogrande/maxtext-vllm-rl-integration
branch
4 times, most recently
from
December 20, 2025 01:43
ff2417e to
6b1618a
Compare
Fix formatting. Refactor model creation and error handling in RL training fix linting. adding no-op mappings to tunix adapter. removing kvcache init for vllm case. latest updates from debugging. adding null logical axis rules to adapter. adding linting fixes. fixing pyink remove unused imports attentions test. adding fixes. addressing comments in evaluate rl. set weight dtype to bf16 by default. removing unecessary logical axis rules. removing epath. removing deprecated .value call
NicoGrande
force-pushed
the
nicogrande/maxtext-vllm-rl-integration
branch
from
December 20, 2025 03:06
6b1618a to
e0e5a25
Compare
copybara-service
Bot
deleted the
nicogrande/maxtext-vllm-rl-integration
branch
December 20, 2025 12:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR finishes the work started by @gagika in #2767. Credits to @gagika for helping with this feature!
This PR adds the changes required to
train_rl.pyas well as other modules related to Tunix integration to allow for additional configurations needed for the MaxText on vLLM flow to be passed to Tunix.More specifically, this PR adds
vllm_additional_configandvllm_hf_config_pathas new arguments such that these values can be pipelined to Tunix for RL.Additionally, this PR makes some small modifications to
tunix_adapter.pyto allow for no-ops to be used as mappings when running RL using MaxText for vLLM.Tests
Gemma3-4B:
Local (v6e-4 VM):
Output: logs
Qwen3-30B-A3B:
v5p-64 Cluster:
Output: logs
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.