Repository navigation
Keep sessions of types this version cannot read - #283
Merged
Merged
Conversation
5cript
changed the title
5cript
changed the title
5cript
enabled auto-merge (rebase)
October 28, 2026 21:32
5cript
disabled auto-merge
October 28, 2026 22:09
5cript
changed the title
…ad warning - A session of an unknown or missing engine type no longer fails the whole load; it is kept whole - State::unreadSessions holds them: from_json sets them aside, to_json writes them back unless a session took the name - The frontend receives them with the state and sends them back with every save - One engine type lookup through boost::describe::enum_from_string, variantDecide switches over the enum - A load warning names the kept sessions, again only when they change
… are kept - Leaving a session in Settings, adding, deleting, renaming and copying sessions and the theme toggle saved the cache - They now load, apply their change to the loaded state and save, like the main Settings save already did
5cript
force-pushed
the
feat/keep-unknown-config-entries
branch
from
October 28, 2026 23:07
91846b6 to
278ff54
Compare
5cript
enabled auto-merge (rebase)
October 28, 2026 23:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of FTP support (#260).
Sessions of an engine type this version does not know, such as
ftpwritten by a newer version, are now kept instead of failing the whole load. This is so that versions from here on out don't delete session types created by later versions.State::unreadSessionsand written back on every save, unless a session of this version took their name.SessionsKeptUnread) names the kept sessions, again only when they change.terminalEngineTypeFromName, decides which engine types are known, andvariantDecideuses it too.