Refactor MODUL_finite to in-memory solver - #105
Open
chemiskyy wants to merge 4 commits into
Open
Conversation
Delete the external path file and rewrite MODUL_finite.py to build the loading path and run the solver entirely in memory. Changes include: remove examples/data/MODUL_finite_path.txt; import and use simcoon.solver with Block/StepMeca and solver.solve; construct log-strain steps in Python; specify corate="logarithmic_R" and control_type="logarithmic"; drop filesystem and legacy numpy file I/O, read measures (LogStrain, Kirchhoff, Wm, Time) from the returned result dict; update plotting and docstrings accordingly; remove unused os/numpy imports. This keeps material and loading path in Python and avoids temporary path/result files on disk.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delete the external path file and rewrite MODUL_finite.py to build the loading path and run the solver entirely in memory. Changes include: remove examples/data/MODUL_finite_path.txt; import and use simcoon.solver with Block/StepMeca and solver.solve; construct log-strain steps in Python; specify corate="logarithmic_R" and control_type="logarithmic"; drop filesystem and legacy numpy file I/O, read measures (LogStrain, Kirchhoff, Wm, Time) from the returned result dict; update plotting and docstrings accordingly; remove unused os/numpy imports. This keeps material and loading path in Python and avoids temporary path/result files on disk.