chore: remove OS file association and deep-link plugin (#145)#205
Open
mattbell87 wants to merge 1 commit into
Open
chore: remove OS file association and deep-link plugin (#145)#205mattbell87 wants to merge 1 commit into
mattbell87 wants to merge 1 commit into
Conversation
File association for .krillnotes and .swarm was unreliable cross-platform (macOS crashes via Finder, cold-start race conditions on Windows/Linux). Users open workspaces via the in-app dialog and swarm files via the menu. Removes tauri-plugin-deep-link and all cold/warm-start file-open handlers. Also adds missing CHANGELOG entry for AppImage .DirIcon symlink fix (PR #203).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fileAssociationsconfig for.krillnotesand.swarmfromtauri.conf.jsontauri-plugin-deep-linkfromCargo.tomland@tauri-apps/plugin-deep-linkfrompackage.jsonhandle_file_opened,handle_krillnotes_open,handle_swarm_open,consume_pending_file_open,consume_pending_swarm_file,AppStatepending-file fields, cold-start file-args block, macOSRunEvent::OpenedhandleruseWorkspaceLifecycle.ts(cold-start and warm-start OS file-open listeners)File association was unreliable cross-platform (macOS crashes via Finder, cold-start race conditions on Windows/Linux). Users open workspaces via the in-app dialog and swarm files via File > Open Swarm File.
Test plan
cargo checkpasses (verified locally)tsc --noEmitpasses (verified locally)krillnotes-coretests pass (verified locally)Closes #145
🤖 Generated with Claude Code