Skip to content

fix(frontend): refine bird icon assets - #409

Merged
Alexander-Noah merged 1 commit into
1024XEngineer:mainfrom
Alexander-Noah:codex/fix-bird-icon
Aug 28, 2026
Merged

fix(frontend): refine bird icon assets#409
Alexander-Noah merged 1 commit into
1024XEngineer:mainfrom
Alexander-Noah:codex/fix-bird-icon

Conversation

@Alexander-Noah

@Alexander-Noah Alexander-Noah commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

变更说明

  • 将启动页资源切换为小鸟图标,并修复边缘白边/突兀感
  • 通过 expo-splash-screen 重新生成 Android 启动页资源
  • 同步更新前端依赖配置

影响范围

  • 仅涉及启动图标 / 启动页资源调整
  • 不包含业务逻辑、后端或数据库变更

与 Issue 的关系

  • 关联 #403
  • PR #407 一起完成 Android 品牌图标资源统一的最终收口

@Alexander-Noah
Alexander-Noah marked this pull request as ready for review August 28, 2026 05:51

@LUPENGHAN LUPENGHAN left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@codecov

codecov Bot commented Aug 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Flag Coverage Δ
backend 96.57% <ø> (-0.08%) ⬇️
frontend 90.71% <ø> (+1.00%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 58 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Alexander-Noah
Alexander-Noah merged commit d2c8ebc into 1024XEngineer:main Aug 28, 2026
9 checks passed
@Alexander-Noah
Alexander-Noah deleted the codex/fix-bird-icon branch August 28, 2026 05:54

@fennoai fennoai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Expo splash configuration and new launcher assets parse successfully, and an isolated Android prebuild completes. However, the PR’s Closes #403 contract is not satisfied: the linked issue requires a dedicated notification icon wired into both expo-notifications and expo-location, plus the native alarm resolver, while this diff only changes launcher/splash assets and leaves the notification configuration and native module unchanged. Please either implement that notification-icon scope in this PR or remove the closing reference before merging.

Verification: npm ci --ignore-scripts, npx expo config --json, isolated npx expo prebuild --platform android --no-install --clean, ESLint, Prettier, and git diff --check passed; expo-doctor still reports pre-existing dependency/version issues.

Comment thread frontend/app.config.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants