Skip to content

Reject nondecimal chain id strings #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
samsamtrum wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Reject nondecimal chain id strings #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/oms-wallet-wagmi-connector/src/provider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,7 +348,7 @@ function normalizeChainId(chainId: Hex | bigint | number | string | undefined):
} else if (typeof chainId === "string" && isHex(chainId)) {
normalized = Number(hexToBigInt(chainId));
} else if (typeof chainId === "string") {
normalized = Number(chainId);
normalized = /^[1-9]\d*$/u.test(chainId) ? Number(chainId) : Number.NaN;
} else {
throw invalidParams("Chain ID is required.");
}
Expand Down
24 changes: 24 additions & 0 deletions packages/oms-wallet-wagmi-connector/tests/omsWalletConnector.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,30 @@ describe("omsWalletConnector", () => {
expect(client.wallet.sendTransaction).not.toHaveBeenCalled();
});

it("rejects non-decimal transaction request chainId strings before calling OMS", async () => {
const client = createClient({walletAddress: "0x9999999999999999999999999999999999999999"});
const config = createWagmiConfig(client);
const connector = config.connectors[0];

await connect(config, {connector});
const provider = await connector.getProvider();

await expect(provider.request({
method: "eth_sendTransaction",
params: [{
from: client.wallet.walletAddress,
to: "0x1111111111111111111111111111111111111111",
value: "0x1",
chainId: "1e2",
}],
})).rejects.toMatchObject({
name: "OmsWalletProviderRpcError",
code: -32602,
message: "Chain ID must be a positive safe integer.",
});
expect(client.wallet.sendTransaction).not.toHaveBeenCalled();
});

it("rejects non-quantity transaction values at the provider boundary", async () => {
const client = createClient({walletAddress: "0x9999999999999999999999999999999999999999"});
const config = createWagmiConfig(client);
Expand Down