fix: validate AES-CBC ciphertext block alignment in Decrypt#6
Open
patrislav wants to merge 2 commits into
Open
fix: validate AES-CBC ciphertext block alignment in Decrypt#6patrislav wants to merge 2 commits into
patrislav wants to merge 2 commits into
Conversation
Add block-size validation after IV removal to prevent panic from cipher.cbcDecrypter.CryptBlocks on malformed (non-block-aligned) ciphertext. Returns a descriptive error instead. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
go.mod requires go >= 1.26.1, but CI workflows were pinned to 1.25.x, causing all jobs to fail. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
aescbc.Decryptafter IV removal to prevent a panic fromcipher.cbcDecrypter.CryptBlockson malformed (non-block-aligned) ciphertextTest plan
TestDecryptBlockSizeValidation/IV_only,_no_data— 16-byte input (IV only) returns errorTestDecryptBlockSizeValidation/non-block-aligned_after_IV— 17-byte input returns errorTestDecryptBlockSizeValidation/block-aligned_after_IV_does_not_panic— 32-byte input does not panicTestDecryptBlockSizeValidation/round-trip— valid encrypt/decrypt still works🤖 Generated with Claude Code