Fix build error caused by ZipKit, outdated XIB files, and removed 'system' function#32
Open
tomaskraina wants to merge 6 commits into
Open
Fix build error caused by ZipKit, outdated XIB files, and removed 'system' function#32tomaskraina wants to merge 6 commits into
tomaskraina wants to merge 6 commits into
Conversation
Added support for extracting 3x assets, similar to how 2x assets are handled. This also requires adding new launch screens so that iPhone 6 and 6 Plus run in their native resolutions instead of the scaled iPhone 5 resolution. Without that, iPhone 6 Plus reports itself as having 2x screen scale instead of 3x. Tested by running the code on the iPhone 6 Plus simulator. Extracted assets were named with the "@3x.png" suffix.
|
Works. Thanks. |
|
+1 This is a minimal change that provides compatibility with the latest iOS (9.3). Can we get this merged? |
|
Tested ACK |
|
<3 |
tomaskraina
changed the title
Author
|
I've just updated my fork so it build in Xcode 10. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #31