chore: migrate store to framework - #2473
Open
SantiagoPittella wants to merge 1 commit into
Open
Conversation
SantiagoPittella
force-pushed
the
santiagopittella-move-store-off-diesel
branch
from
August 14, 2026 14:39
3cbead5 to
3055231
Compare
SantiagoPittella
force-pushed
the
santiagopittella-move-store-off-diesel
branch
from
August 14, 2026 20:51
3055231 to
4e225c9
Compare
SantiagoPittella
force-pushed
the
santiagopittella-move-store-off-diesel
branch
from
August 18, 2026 15:57
4e225c9 to
59ba90f
Compare
SantiagoPittella
force-pushed
the
santiagopittella-move-store-off-diesel
branch
2 times, most recently
from
August 18, 2026 16:02
5d0d589 to
2f58517
Compare
SantiagoPittella
force-pushed
the
santiagopittella-move-store-off-diesel
branch
from
August 19, 2026 13:04
2f58517 to
8acbacc
Compare
Mirko-von-Leipzig
force-pushed
the
santiagopittella-move-store-off-diesel
branch
from
August 19, 2026 13:56
8acbacc to
721a2e6
Compare
Collaborator
Is the problem that we cannot have both a rusqlite pool, and a diesel pool? I thought perhaps one could migrate one function/rpc call at a time if we support both for the transition? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm extremely sorry about the size of the diff. We can reduce the diff size by split in different chunks but that will make the node not to work until all of the PRs are merged. Also thought of using a feature branch and merging little PRs there, but if that branch diverges from
nextthe conflicts can become a real pain (though maybe we prefer that pain over this diff). Let me know what do you think.Summary
This PR mgirates the
storecrate to the SQLite framework that we previously introduced, and moves off of diesel. It copies the structure of the other crates, with a query dir and a folder-per-query. Most of the changes are just moving things around.The actual removal of the diesel dependency and our helpers is going to be done in a follow up PR.
Changelog