From 9a48700c842f4e230c70bd77e9f3c888c4a396ba Mon Sep 17 00:00:00 2001 From: Adam Gutglick Date: Fri, 7 Aug 2026 18:12:22 +0100 Subject: [PATCH 1/2] Upload debug info and binaries in parallel after building SQL benchmarks Signed-off-by: Adam Gutglick --- .github/workflows/sql-bench-matrix.yml | 43 +++++++++++++------------- 1 file changed, 22 insertions(+), 21 deletions(-) diff --git a/.github/workflows/sql-bench-matrix.yml b/.github/workflows/sql-bench-matrix.yml index 9cd246e4c4f..c91178eda36 100644 --- a/.github/workflows/sql-bench-matrix.yml +++ b/.github/workflows/sql-bench-matrix.yml @@ -74,27 +74,28 @@ jobs: packages+=(--bin lance-bench) fi cargo build "${packages[@]}" --profile release_debug --features unstable_encodings - - name: Upload binaries - uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7 - with: - name: bench-binaries - path: | - target/release_debug/data-gen - target/release_debug/datafusion-bench - target/release_debug/duckdb-bench - target/release_debug/lance-bench - target/release_debug/build/vortex-duckdb-cache/duckdb-lib-*-prebuilt/libduckdb.so - - name: Pre-upload SQL benchmark debuginfo to Polar Signals - if: inputs.mode != 'pr' || github.event.pull_request.head.repo.fork == false - uses: ./.github/actions/upload-parca-debuginfo - continue-on-error: true - with: - paths: | - target/release_debug/datafusion-bench - target/release_debug/duckdb-bench - ${{ inputs.mode != 'pr' && 'target/release_debug/lance-bench' || '' }} - polarsignals-cloud-token: ${{ secrets.POLAR_SIGNALS_API_KEY }} - project-id: "e5d846e1-b54c-46e7-9174-8bf055a3af56" + - parallel: + - name: Upload binaries + uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7 + with: + name: bench-binaries + path: | + target/release_debug/data-gen + target/release_debug/datafusion-bench + target/release_debug/duckdb-bench + target/release_debug/lance-bench + target/release_debug/build/vortex-duckdb-cache/duckdb-lib-*-prebuilt/libduckdb.so + - name: Pre-upload SQL benchmark debuginfo to Polar Signals + if: inputs.mode != 'pr' || github.event.pull_request.head.repo.fork == false + uses: ./.github/actions/upload-parca-debuginfo + continue-on-error: true + with: + paths: | + target/release_debug/datafusion-bench + target/release_debug/duckdb-bench + ${{ inputs.mode != 'pr' && 'target/release_debug/lance-bench' || '' }} + polarsignals-cloud-token: ${{ secrets.POLAR_SIGNALS_API_KEY }} + project-id: "e5d846e1-b54c-46e7-9174-8bf055a3af56" bench: needs: [resolve-matrix, build] From d6b98bbd3398a4c78afc4d0cadaffdb5d6285cc8 Mon Sep 17 00:00:00 2001 From: Adam Gutglick Date: Fri, 7 Aug 2026 18:18:34 +0100 Subject: [PATCH 2/2] fix Signed-off-by: Adam Gutglick --- .github/workflows/sql-bench-matrix.yml | 42 +++++++++++++------------- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/.github/workflows/sql-bench-matrix.yml b/.github/workflows/sql-bench-matrix.yml index c91178eda36..3805437cbf5 100644 --- a/.github/workflows/sql-bench-matrix.yml +++ b/.github/workflows/sql-bench-matrix.yml @@ -75,27 +75,27 @@ jobs: fi cargo build "${packages[@]}" --profile release_debug --features unstable_encodings - parallel: - - name: Upload binaries - uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7 - with: - name: bench-binaries - path: | - target/release_debug/data-gen - target/release_debug/datafusion-bench - target/release_debug/duckdb-bench - target/release_debug/lance-bench - target/release_debug/build/vortex-duckdb-cache/duckdb-lib-*-prebuilt/libduckdb.so - - name: Pre-upload SQL benchmark debuginfo to Polar Signals - if: inputs.mode != 'pr' || github.event.pull_request.head.repo.fork == false - uses: ./.github/actions/upload-parca-debuginfo - continue-on-error: true - with: - paths: | - target/release_debug/datafusion-bench - target/release_debug/duckdb-bench - ${{ inputs.mode != 'pr' && 'target/release_debug/lance-bench' || '' }} - polarsignals-cloud-token: ${{ secrets.POLAR_SIGNALS_API_KEY }} - project-id: "e5d846e1-b54c-46e7-9174-8bf055a3af56" + - name: Upload binaries + uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7 + with: + name: bench-binaries + path: | + target/release_debug/data-gen + target/release_debug/datafusion-bench + target/release_debug/duckdb-bench + target/release_debug/lance-bench + target/release_debug/build/vortex-duckdb-cache/duckdb-lib-*-prebuilt/libduckdb.so + - name: Pre-upload SQL benchmark debuginfo to Polar Signals + if: inputs.mode != 'pr' || github.event.pull_request.head.repo.fork == false + uses: ./.github/actions/upload-parca-debuginfo + continue-on-error: true + with: + paths: | + target/release_debug/datafusion-bench + target/release_debug/duckdb-bench + ${{ inputs.mode != 'pr' && 'target/release_debug/lance-bench' || '' }} + polarsignals-cloud-token: ${{ secrets.POLAR_SIGNALS_API_KEY }} + project-id: "e5d846e1-b54c-46e7-9174-8bf055a3af56" bench: needs: [resolve-matrix, build]