Skip to content

Fix grouped sum regression after sql semantics change #9293

Description

@mhk197

Merging this PR will regress 10 benchmarks

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 9 improved benchmarks
❌ 10 regressed benchmarks
✅ 1918 untouched benchmarks
🆕 4 new benchmarks
⏩ 85 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation sum_f64_all_valid 87.7 µs 194.5 µs -54.91%
Simulation sum_i32_nullable_all_valid 95.2 µs 185.9 µs -48.77%
Simulation fsl_sum_small 136.3 µs 212.8 µs -35.94%
Simulation sum_i32_clustered_nulls 150.2 µs 230.8 µs -34.9%
Simulation sum_f64_clustered_nulls 158.1 µs 238.8 µs -33.77%
Simulation listview_sum_small 174.7 µs 223.7 µs -21.92%
Simulation cold_misaligned[(64, 256)] 4.4 ms 5 ms -12.62%
Simulation search_index_in_range_chunked 5.6 ms 6.4 ms -11.64%
Simulation list_sum_small 279.2 µs 315.4 µs -11.49%
Simulation sparse_null_count 77.3 µs 86.2 µs -10.37%
Simulation list_sum_nullable_elements_medium 11.6 ms 4.7 ms ×2.5
Simulation list_sum_nullable_elements_large 1,093.1 ms 464.4 ms ×2.4
Simulation listview_sum_large 231.7 ms 150.5 ms +53.93%
Simulation fsl_sum_medium 1.7 ms 1.2 ms +49.74%
Simulation list_sum_large 275.4 ms 185.4 ms +48.56%
Simulation fsl_sum_large 140 ms 96.5 ms +45%
Simulation listview_sum_medium 2.1 ms 1.6 ms +30.48%
Simulation list_sum_medium 2.5 ms 2 ms +27.38%
Simulation count_i32_clustered_nulls 113.9 µs 102.6 µs +11.02%
🆕 Simulation canonical_sum_f64_all_valid N/A 211.6 µs N/A
... ... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing mk/unify-sums-v2 (e2b15cb) with develop (19f771f)

Open in CodSpeed

Originally posted by @codspeed-hq[bot] in #9113 (comment)

Footnotes

  1. 85 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions