Skip to content

Object Count Statistics is not including all arrays (catches first one) #26

Description

@utkuakyuz

high

The current array matching logic, which finds the first new array that shares at least one key with an old array (commonKeys.length > 0), could be fragile. If an old array could potentially match multiple new arrays, this logic will arbitrarily pick the first one it finds. This may not be the best match (e.g., the one with the most overlap), which could lead to inaccurate object change counts.

Consider a more robust matching strategy, perhaps by calculating an "overlap score" (e.g., based on the number of common keys) and choosing the pair with the highest score. This would make the statistics more reliable, especially for complex diffs.

Originally posted by @gemini-code-assist[bot] in #25 (comment)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions