persist colors for shared calendars

[TheOnAndOnlyZenomat]

Problem / motivation

Hi,

Thanks for building this tool. I looked for an eternity to find a caldav server with easy user management and calendar sharing. This wrapped all that is a nice and simple package :D

I have a problem tho: when importing a calendar shared from another user the calendar color does not get shared as as well. Looking at the sabre dashboard from davis I can that the color is only present in owned calendars, not in shared.

This is especially a problem when using it with davx on android, as all calendars without a specific color get assigned green.

Is this a spec problem or something that could conceivably be worked around?

Proposed solution

The shared calendars should be assigned the color from the source calendar.

Alternatives considered

In my android calendar app (fossify calendar) I assigned custom colors to those shared calendars, but they get reset when davx synchronizes the calendar list.

Area

CalDAV

Additional context

No response

[TheOnAndOnlyZenomat]

I found a (partial) solution: You can edit the calendars shared with you and assign a custom color there.

It would still be nice if davis would pick the color of the source calendar automatically. Because with the solution from above I still need to update the colors for every shared calendar for every user manually.

[tchapi]

Hi

when importing a calendar shared from another user

Can you precise exactly what you mean by importing? You mean when you share the calendar via the Davis dashboard?

Note that I understand we're talking about color assignment at once, not a continuous update (ie if the sharer updates the color on their side, it won't get ported to all the sharees)

[TheOnAndOnlyZenomat]

What I mean is:

1. I create a calendar on account 1 and assign it the color red
2. I share that calendar with account 2 via the davis dashboard
3. Account 2 is then synced via Davx5 on Android

In Davx5 the calendar does not have the color red by default. I have to manually assign the color in the davis dashboard in the shared calendar on account 2.

Assigning the color only once on share is fine in my book. Tho an argument could be made that it should be updated for all sharees if they did not explicitly set a color for that shared calendar themselves.

[tchapi]

Could you check that #266 fixes your use case (initial seeding, no later tracking) ?

[TheOnAndOnlyZenomat]

Hi, thanks for the quick fix. Could you give me a pointer for how to test this with my docker deployment? Or do I just copy my database and do a local install for that?

[tchapi]

You can test locally yes (by checking out this branch), or, given the fix is simple, just add the two lines directly in your container code

[TheOnAndOnlyZenomat]

I checked it out, it seems to work. Awesome, thank you <3

[tchapi]

Thanks a lot for your donation 🫶
Will include the latest fixes in a release today or tomorrow