fix(lint): keep react compiler diagnostics advisory

[drewstone]

Summary

• keep React hook-order violations as CI errors
• keep React Compiler readiness diagnostics visible as warnings after the hooks-plugin 7.1.1 bump
• restores fresh-install repo-wide lint without downgrading eslint-plugin-react-hooks

Verification

• yarn format:check
• NX_DAEMON=false NX_SKIP_NX_CACHE=true yarn nx run-many --all --target=lint --skip-nx-cache
• pre-push hook lint/format/build

Follow-up to #3259 because that PR was merged while this one-file CI fix was being pushed.

[tangletools]

✅ No Blockers — 15f6d294

Readiness 89/100 · Confidence 65/100 · 2 findings (2 low)

	deepseek	glm	aggregate
Readiness	95	89	89
Confidence	65	65	65
Correctness	95	89	89
Security	95	89	89
Testing	95	89	89
Architecture	95	89	89

Full multi-shot audit completed 1/1 planned shots over 1 changed files. Global verifier still owns final merge decision. | Full multi-shot audit completed 1/1 planned shots over 1 changed files. Global verifier still owns final merge decision.

🟡 LOW No CI lint run evidence in this PR — eslint.config.js

The diff adds 15 new lint rules (13 warn + 2 error/warn). While the config parses correctly and a spot-check lint passes, there's no evidence in this shot that yarn lint passes across the entire monorepo. The rules-of-hooks set to 'error' could break CI if existing code violates it. Mitigated by the fact that Nx React preset likely already enabled these rules via the plugin — the explicit declarations may be redundant overrides. Risk is low but non-zero.

🟡 LOW Potential rule duplication with Nx React preset — eslint.config.js

The Nx React preset (...nxEslintPlugin.configs['flat/react']) at line 33 likely already configures react-hooks/rules-of-hooks and react-hooks/exhaustive-deps. The explicit declarations at lines 58-59 override rather than conflict, but if the Nx preset changes its defaults in a future upgrade, these explicit settings will silently win. The comment at lines 60-62 documents intent well, so this is a minor maintenance consideration.

---

_{tangletools · 2026-06-08T10:22:40Z · trace}

[tangletools]

✅ Approved — 2 non-blocking findings — 15f6d294

Full multi-shot audit completed 1/1 planned shots over 1 changed files. Global verifier still owns final merge decision. | Full multi-shot audit completed 1/1 planned shots over 1 changed files. Global verifier still owns final merge decision.

Full immutable report for this review: trace

Summary comment for this run: full summary

---

_{tangletools · 2026-06-08T10:22:40Z · immutable trace}