fix: hold spark sends while a wallet restore is pending

Author: ovitrif

app/src/main/java/to/bitkit/repositories/LightningRepo.kt

@@ -1450,7 +1450,9 @@ class LightningRepo @Inject constructor(
         onBeforeSend: suspend () -> Boolean,
     ): Result<PaymentId> {
         if (shouldPayWithSpark(bolt11, sats)) {
+            runCatching { requireWalletRestoreComplete() }.onFailure { return Result.failure(it) }
             if (!onBeforeSend()) return Result.failure(PaymentAbortedBeforeSend())
+            runCatching { requireWalletRestoreComplete() }.onFailure { return Result.failure(it) }
             return sparkRepo.payInvoice(bolt11, sats)
         }
         return payInvoiceWithLdk(bolt11, sats, paymentDeadlineAt, maxTotalRoutingFeeMsat, onBeforeSend)

app/src/test/java/to/bitkit/repositories/LightningRepoTest.kt

@@ -1102,6 +1102,37 @@ class LightningRepoTest : BaseUnitTest() {
         verify(lightningService, never()).send(any(), anyOrNull(), anyOrNull(), anyOrNull())
     }
 
+    @Test
+    fun `pending wallet recovery prevents spark payment dispatch`() = test {
+        startNodeForTesting()
+        whenever(sparkRepo.canSend(1_000uL)).thenReturn(true)
+        whenever(keychain.exists(Keychain.Key.PAYKIT_PENDING_BACKUP_RESTORE.name)).thenReturn(true)
+        var beforeSend = false
+
+        val result = sut.payInvoice("invoice", 1_000uL, onBeforeSend = {
+            beforeSend = true
+            true
+        })
+
+        assertIs<WalletBackupRestorePendingError>(result.exceptionOrNull())
+        assertFalse(beforeSend)
+        verify(sparkRepo, never()).payInvoice(any(), anyOrNull())
+    }
+
+    @Test
+    fun `restore beginning during spark payment authorization prevents dispatch`() = test {
+        startNodeForTesting()
+        whenever(sparkRepo.canSend(1_000uL)).thenReturn(true)
+
+        val result = sut.payInvoice("invoice", 1_000uL, onBeforeSend = {
+            whenever(keychain.exists(Keychain.Key.PAYKIT_PENDING_BACKUP_RESTORE.name)).thenReturn(true)
+            true
+        })
+
+        assertIs<WalletBackupRestorePendingError>(result.exceptionOrNull())
+        verify(sparkRepo, never()).payInvoice(any(), anyOrNull())
+    }
+
     @Test
     fun `restore beginning during payment authorization prevents dispatch`() = test {
         startNodeForTesting()