Skip to content

fix: kg_emb broken import in PyHealth 2.0 #952

@capccode

Description

@capccode

kg_emb/ references SampleBaseDataset which appears to have been renamed to SampleDataset in PyHealth 2.0. Anyone who imports pyhealth.medcode.pretrained_embeddings gets an ImportError and package would crash immediately. Found this while implementing KEEP embeddings in personal fork. Currently adding a try/e bandaid in my fork but is out of scope for the KEEP work. Likely impacts all 6 files in kg_emb.models and the 2 in kg_emb/datasets. I can rename SampleBaseDataset --> SampleDataset across the 8 files if no one gets to it.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions